Skip to content

test(lib): fix SIGSEGV on x86_64-unknown-linux-gnu targets #29794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanwhit merged 1 commit into from
Jun 18, 2025
Merged

test(lib): fix SIGSEGV on x86_64-unknown-linux-gnu targets #29794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tests/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ bytes.workspace = true
chrono = { workspace = true, features = ["now"] }
deno_bench_util.workspace = true
deno_cache_dir.workspace = true
deno_core = { workspace = true, features = ["unsafe_use_unprotected_platform"] }
Copy link
Member

@dsherret dsherret Jun 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency isn't used by the tests crate. I'll do a follow-up pr to fix this.

Copy link
Contributor Author

@limwa limwa Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it have gone into the dev_dependencies in cli/Cargo.toml?

Copy link
Member

@dsherret dsherret Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's what I did in #29806 which should cause the other crates to be built with that feature enabled without adding a dependency to deno_core for the tests crate.

deno_lockfile.workspace = true
deno_semver.workspace = true
deno_terminal.workspace = true
Expand Down
Loading