-
Notifications
You must be signed in to change notification settings - Fork 27
CP-6007 Futurize vSDK - Stage 2 CP-6009 Add to_str and to_byte helpers #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbbb83f to
d5d088c
Compare
3b49c11 to
51d0a0d
Compare
nhlien93
reviewed
Nov 9, 2021
tools/src/main/python/dlpx/virtualization/_internal/codegen/templates/base_model_.mustache
Show resolved
Hide resolved
tools/src/main/python/dlpx/virtualization/_internal/plugin_importer.py
Outdated
Show resolved
Hide resolved
tools/src/test/python/dlpx/virtualization/_internal/commands/test_initialize.py
Outdated
Show resolved
Hide resolved
tools/src/test/python/dlpx/virtualization/_internal/test_cli.py
Outdated
Show resolved
Hide resolved
mothslaw
reviewed
Nov 10, 2021
tools/src/main/python/dlpx/virtualization/_internal/codegen/templates/util.mustache
Show resolved
Hide resolved
mothslaw
approved these changes
Nov 11, 2021
nhlien93
approved these changes
Nov 11, 2021
Contributor
nhlien93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good just a couple more nits! Thanks for getting this done.
tools/src/main/python/dlpx/virtualization/_internal/commands/initialize.py
Show resolved
Hide resolved
14a0c2e to
73f528f
Compare
mrburke
pushed a commit
that referenced
this pull request
Jan 12, 2022
* DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
mrburke
pushed a commit
to mrburke/virtualization-sdk
that referenced
this pull request
Jan 13, 2022
* DOC-1074 Document password vault support for VSDK plugins (delphix#347) * Correct Typo in Example, it should be UNIX not WINDOWS (delphix#360) * Add documentation for gRPC message and memory limits delphix#390 (delphix#391) * Fix version number in doc header (delphix#358) (delphix#397) * Update Delphix Engine version required to 6.0.7.0. (delphix#386) (delphix#398) * Update SDK Docs deployment to use a deploy_key (delphix#392) (delphix#399) * CP-6005 Ensure vSDK test coverage (delphix#403) * CP-6006 Futurize vSDK - Stage 1 (delphix#404) * Add support for virtualCleanup decorator (delphix#400) (delphix#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes delphix#401 Networking capabilities should be documented (delphix#402) Fixes delphix#401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (delphix#407) * CP-6621 bump sdk version to 4.0.0 (delphix#409) * CP-6694 Update docs for SDK 4.0.0 (delphix#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (delphix#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (delphix#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
mrburke
pushed a commit
that referenced
this pull request
Jan 13, 2022
* DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
mrburke
pushed a commit
that referenced
this pull request
Jan 20, 2022
* CP-7022 vSDK 4.0.0 release tasks (#416) * Bumping sdk to 4.0.2 and dvp-api to 1.6.3 due to bad upload of dvp-api 1.6.1 to pypi (#419) * Release (#418) * DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> * Release (#418) (#421) * DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP-6007 Futurize vSDK - Stage 2
CP-6009 Add to_str and to_byte helpers
CP-6010 Add Github Action(s) to run vSDK unit tests in py3
CP-6250 Remove
toolsfrom py2.7 unit tests in github actionsContext:
This diff introduces Python3.8 support for the Delphix vSDK.
What does this mean for plugin authors?
dvpmay only be installed and used with Python 3.8What exactly is in this diff?
futurize --stage2was run and I then manually cleaned up some of its changes. For example it wraps any instance of<dict object>.[keys|values|items]()withlist(), which is not always necessary and should in some situations have the potential to be slower (though in truth it shouldn't be a significant slowdown for our use cases)to_bytesandto_strfunctions which work with python 2 and 3 and handles a number of data types.common,libs,platformcommon,libs,platform,toolscommon,libs,platformcommon,libs,platform,toolscommon,libs, andplatformwere not being linted prior to this diff, so there are a handful of simple formatting fixes throughout the diff as well.if six.PY2: ... else:lines from the relevant test files.dvp/setup.cfgto require Python 3.8Testing
qa-gate and qa-toolkits changes must be made before we can automate py3 plugin testing. These changes are in progress. However py2 still looks good, and manual testing with py3 looks good so far as well.
Testing with new PY38 qa-appdata-toolkits plugins looks good. Continuing on automation.
All the pre-commit actions have passed.