CP-6006 Futurize vSDK - Stage 1 #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrburke
requested review from
ankursarin,
mothslaw and
nhlien93
as code owners
nhlien93
approved these changes
Oct 5, 2021
ravi-cm
reviewed
Oct 5, 2021
Contributor
ravi-cm
left a comment
ravi-cm
left a comment
There was a problem hiding this comment.
Could you please check tools/..../exceptions.py - SchemaValidationError to see if any of the code added to parse the unicode encoded string/s from jsonschema validation errors needs a change?
mothslaw
approved these changes
Oct 5, 2021
Contributor
Author
Just commenting to reflect that we spoke offline, CP-6009 will cover the types of changes mentioned by Ravi above |
ravi-cm
approved these changes
Oct 5, 2021
Contributor
ravi-cm
left a comment
ravi-cm
left a comment
There was a problem hiding this comment.
Checked w/ Zach and upcoming changes will take care of the changes in excpetions.py if need be.
mrburke
pushed a commit
that referenced
this pull request
Jan 12, 2022
* DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
mrburke
pushed a commit
to mrburke/virtualization-sdk
that referenced
this pull request
Jan 13, 2022
* DOC-1074 Document password vault support for VSDK plugins (delphix#347) * Correct Typo in Example, it should be UNIX not WINDOWS (delphix#360) * Add documentation for gRPC message and memory limits delphix#390 (delphix#391) * Fix version number in doc header (delphix#358) (delphix#397) * Update Delphix Engine version required to 6.0.7.0. (delphix#386) (delphix#398) * Update SDK Docs deployment to use a deploy_key (delphix#392) (delphix#399) * CP-6005 Ensure vSDK test coverage (delphix#403) * CP-6006 Futurize vSDK - Stage 1 (delphix#404) * Add support for virtualCleanup decorator (delphix#400) (delphix#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes delphix#401 Networking capabilities should be documented (delphix#402) Fixes delphix#401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (delphix#407) * CP-6621 bump sdk version to 4.0.0 (delphix#409) * CP-6694 Update docs for SDK 4.0.0 (delphix#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (delphix#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (delphix#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
mrburke
pushed a commit
that referenced
this pull request
Jan 13, 2022
* DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
mrburke
pushed a commit
that referenced
this pull request
Jan 20, 2022
* CP-7022 vSDK 4.0.0 release tasks (#416) * Bumping sdk to 4.0.2 and dvp-api to 1.6.3 due to bad upload of dvp-api 1.6.1 to pypi (#419) * Release (#418) * DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> * Release (#418) (#421) * DOC-1074 Document password vault support for VSDK plugins (#347) * Correct Typo in Example, it should be UNIX not WINDOWS (#360) * Add documentation for gRPC message and memory limits #390 (#391) * Fix version number in doc header (#358) (#397) * Update Delphix Engine version required to 6.0.7.0. (#386) (#398) * Update SDK Docs deployment to use a deploy_key (#392) (#399) * CP-6005 Ensure vSDK test coverage (#403) * CP-6006 Futurize vSDK - Stage 1 (#404) * Add support for virtualCleanup decorator (#400) (#405) Co-authored-by: Kurt Hutchison <[email protected]> * Fixes #401 Networking capabilities should be documented (#402) Fixes #401 Networking capabilities should be documented * CP-6009 Add to_str and to_byte helpers (#407) * CP-6621 bump sdk version to 4.0.0 (#409) * CP-6694 Update docs for SDK 4.0.0 (#410) * CP-7022 vSDK 4.0.0 release tasks * Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414) Co-authored-by: Kurt Hutchison <[email protected]> * Update documentation with new gRPC message limits (#415) Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]> Co-authored-by: Raul Santelices <[email protected]> Co-authored-by: Ranzo J Taylor, III <[email protected]> Co-authored-by: Jeff Ngo <[email protected]> Co-authored-by: Ankur <[email protected]> Co-authored-by: kurthdelphix <[email protected]> Co-authored-by: Kurt Hutchison <[email protected]> Co-authored-by: Tom Walsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This change begins preparing for the move to Python3.8 by running
futurize --stage1 ...against all 5 packages (very few changes), and by usingsixto remove all direct references tobasestringin the source code. CP-6009 will handle all other vSDK changes for this project. In Py2,six.string_types = [basestring]and in Py3,six.string_types = [str]. This will also take a little bit of weight off of the upcoming CP-6009 review, which can then focus mainly on introducingto_strandto_byteshelpers across the repo as necessary.Testing
Blackbox:
virtualization_sdk
appdata_basic
and unit tests passed