CP-3163 Add authentication object to AppData with vault option#244
Merged
rasantel merged 16 commits intodelphix:projects/password-vault-pluginsfrom Nov 10, 2020
Merged
CP-3163 Add authentication object to AppData with vault option#244rasantel merged 16 commits intodelphix:projects/password-vault-pluginsfrom
rasantel merged 16 commits intodelphix:projects/password-vault-pluginsfrom
Conversation
rasantel
requested review from
ankursarin,
fdrozdowski and
nhlien93
as code owners
rasantel
changed the base branch from
develop
to
projects/password-vault-plugins
rasantel
force-pushed
the
CP-3163
branch
2 times, most recently
from
7724cba to
73806d8
Compare
…hix#254) * Fixes delphix#253 Move some CLI tests from Blackbox to SDK repo * Fix linting issue * Fix linting issue - unalignment * Address comments regarding expected error * Add a few negative scenarios to test plugin importer * Fixed the linting issue * Fixed the linting issue * Add a couple more tcs * Remove debug statements * Ttypo in testcase name * Address review comments from Lindsey
Merge from delphix branch
mothslaw
reviewed
Oct 5, 2020
common/src/main/python/dlpx/virtualization/common/_common_classes.py
Outdated
Show resolved
Hide resolved
Fixes delphix#258 Add clearer doc for JSON schema's default keyword
…to none when json is empty (delphix#260)
rasantel
force-pushed
the
CP-3163
branch
4 times, most recently
from
3120769 to
8c3652e
Compare
Fixes delphix#262 Add test_virtual_initialize_return_none
nhlien93
reviewed
Oct 23, 2020
rasantel
force-pushed
the
CP-3163
branch
3 times, most recently
from
0a6be8b to
d093637
Compare
mothslaw
approved these changes
Oct 28, 2020
nhlien93
approved these changes
Nov 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See http://reviews.delphix.com/r/60256 for details and testing.
This PR adds a wrapper for the new
retrieve_credentialscallback and wrapper credentials classes that represent the result of that callback. It also fixes the generation of the swagger json schema so that it will handle references to external definitions (swagger is not able to handle those) as opaque objects that the plugin is not supposed to manipulate, but rather just pass back to the callback.