Fixes #250 Support empty VDBs #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from delphix branch
jeffngo
reviewed
Sep 11, 2020
jeffngo
reviewed
Sep 11, 2020
jeffngo
reviewed
Sep 11, 2020
Contributor
Author
|
New image for docs:
|
jeffngo
approved these changes
Sep 11, 2020
ravi-cm
reviewed
Sep 11, 2020
tools/src/main/python/dlpx/virtualization/_internal/validation_schemas/plugin_importer.yaml
Show resolved
Hide resolved
nhlien93
approved these changes
Sep 14, 2020
Contributor
nhlien93
left a comment
nhlien93
left a comment
There was a problem hiding this comment.
some comments on docs but feel free to drop.
| ## Empty VDB | ||
| A VDB that is created from scratch, without provisioning from another dataset. Users can create empty VDBs when they want to construct a brand-new dataset from within Delphix, instead of creating it externally and then ingesting it. | ||
|
|
||
| This "empty" VDB, of course, will typically not stay empty for long. Data will be added as users work with the new dataset. |
Contributor
There was a problem hiding this comment.
kinda nit, I'm not sure I like this sentence but my suggestions aren't much better. Maybe instead of saying like ths vdb will typically not stay empty for long we can write a more clear sentence about how it starts out empty but can have things written into it depending on the user?
You can leave it this way if too if you disagree with my suggestion.
|
|
||
| ## Virtual Source Initialize | ||
|
|
||
| Initializes a brand-new [empty VDB](Glossary.md#empty-vdb). As with all VDBs, this new dataset will have access to mounted Delphix Engine storage, but of course there will be no data there at first. |
Contributor
There was a problem hiding this comment.
again not sure if "of course" part really make sense here. I think it's reasonable just to have the sentence say something like:
Initializes a brand-new empty VDB. As with all VDBs, this new dataset will have access to mounted Delphix Engine storage. The VDB will however start out with no data.```
or something along these lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
SDK plugins cannot participate in the Empty VDBs feature.
What is the new behavior?
Plugins can now optionally define an
initializeoperation. This will allow engine users to create empty VDBs against this plugin. (If the plugin does not define the operation, then it does not support empty VDBs, which is totally fine)Does this introduce a breaking change?
This kinda looks like a breaking change due to the API changes. However, this feature never worked, and so there is no plugin that could possibly be broken by this change.
Other information
Tested by building one plugin with an
initializeoperation, and one without. Using a trunk engine, confirmed I could create empty VDBs with one plugin but not the other.