Update SDK to add SnapshotParametersDefinition in uploaded artifact #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhlien93
force-pushed
the
snapshotparams
branch
3 times, most recently
from
d6f968e to
cdda079
Compare
nhlien93
force-pushed
the
snapshotparams
branch
from
3cf0e0d to
4bc500d
Compare
nhlien93
force-pushed
the
snapshotparams
branch
from
f1e0feb to
80b3992
Compare
mothslaw
approved these changes
Sep 25, 2020
| direct_source=direct_source, | ||
| repository=repository, | ||
| source_config=source_config, | ||
| optional_snapshot_parameters=snapshot_parameters) |
Contributor
There was a problem hiding this comment.
I love the idea of putting the word "optional" right in the argument name here.
Contributor
Author
There was a problem hiding this comment.
haha it was your idea! so thank you 🥇
Contributor
There was a problem hiding this comment.
It was?? I have no memory of this.
jeffngo
reviewed
Sep 25, 2020
tools/src/test/python/dlpx/virtualization/_internal/fake_plugin/direct/successful.py
Show resolved
Hide resolved
tools/src/test/python/dlpx/virtualization/_internal/fake_plugin/direct/multiple_warnings.py
Show resolved
Hide resolved
jeffngo
approved these changes
Sep 25, 2020
ankursarin
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Cannot define snapshot parameters. Staged plugins do have a "snapshot parameter" that is defined to have a resync boolean.
What is the new behavior?
optional_snapshot_parametersnow (direct and staged)Does this introduce a breaking change?
This change will mean anyone that wants to build a plugin with this version of the SDK will have to update two things:
the schema file needs to have the
snapshot_parameters_definitionand the source code needs to add theoptional_snapshot_parametersto the pre_snapshot / post_snapshot operations.Tests were run on the appgate side. Also added new unit test to verify that dvp init -> dvp build works because init should always create a buildable plugin.