fix: sync develop#253
Merged
agusduha merged 59 commits intosc-feat/add-shared-lockboxfrom Feb 4, 2025
Merged
Conversation
* Change step name * Move to circle ci * Fix config.yml
…imism#14027) * op-program: Fix missing block re-exec preimages in host * check put key length
* try * try again * try again * try again * use semver lock to check * use semver lock to check * fixes * fixes * should break * fix * fix * should break 2 * should break 2 * should break 2 * should break 2 * temp rm require config for faster checks * temp rm require config for faster checks * temp rm require config for faster checks * rm debug lines * should break 3 * fix * fix * fix * Update packages/contracts-bedrock/scripts/checks/check-frozen-files.sh Co-authored-by: Maurelian <john@oplabs.co> --------- Co-authored-by: Maurelian <john@oplabs.co>
* docs: Add frozen code checks docs to readme. * feat: Add lift date to script output
* Fix damgr_test.go * Enable AltDA unit tests in ci * typo
The readme linked to the kurtosis install guide but for mac users it only lists brew as an installation option, for non brew users a link to the compiled binaries is useful.
…sm#13861) Bumps [github.com/minio/minio-go/v7](https://github.com/minio/minio-go) from 7.0.81 to 7.0.84. - [Release notes](https://github.com/minio/minio-go/releases) - [Commits](minio/minio-go@v7.0.81...v7.0.84) --- updated-dependencies: - dependency-name: github.com/minio/minio-go/v7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ci: Raise parallelism of cannon-e2e tests * ci: Build op-program-host and cannon before running go tests. * op-geth: Update op-geth to avoid loading and parsing all genesis files. Specifically includes ethereum-optimism/op-geth#482 * Consistently build 64-bit multithreaded prestates with -mt64 suffix. Previously the native build used -mt and the reproducible build used -mt64. Stop building the 32-bit multithreaded prestate in reproducible builds. --------- Co-authored-by: Matthew Slipper <me@matthewslipper.com>
…14019) * proofs: Add action test for unhappy consolidation The test covers the unhappy path in the consolidation step of the fault proof where an invalid message triggers a block replacement * remove redundant test * assert heads
This is because alerts use `increase()` to detect changes in the metrics, and the first instance of a metric is not considered a change, so detecting failures doesn't fire unless the metric was already 0.
…ptimism#13872) Bumps [github.com/consensys/gnark-crypto](https://github.com/consensys/gnark-crypto) from 0.12.1 to 0.15.0. - [Release notes](https://github.com/consensys/gnark-crypto/releases) - [Changelog](https://github.com/Consensys/gnark-crypto/blob/master/CHANGELOG.md) - [Commits](Consensys/gnark-crypto@v0.12.1...v0.15.0) --- updated-dependencies: - dependency-name: github.com/consensys/gnark-crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
In ethereum-optimism#13772, the L1 cache size was made configurable and the cap of 1000 was removed. This implied that the old default value (before applying the cap) of 2/3 the sequencing window was now active. However, high-throughput chains don't need such a high cache size under normal conditions, so memory usage unexpectedly jumped for most node operators. This PR adds back a lower default value of 900, which is a better default for most nodes. Only low-throughput chains with infrequent safe head increments can now use this flag to set a higher value.
* op-deployer: Support upgrades * semgrep * imports * cr updates * remove aliasing * goimports * cr updates * fix lint --------- Co-authored-by: Samuel Stokes <sam.adam.stokes@gmail.com>
…mism#14025) * feat: prevent deployments of mips32 on opcm upgrade 13 * feat: Ensure that fork tests deploy mips64 * fix: error string in tests * fix test name
* skip implementation upgrade and system config initialization tests for superchain ops tests * fmt * update gas snapshot
…ethereum-optimism#14074) Bumps [github.com/lmittmann/w3](https://github.com/lmittmann/w3) from 0.17.4 to 0.17.5. - [Release notes](https://github.com/lmittmann/w3/releases) - [Commits](lmittmann/w3@v0.17.4...v0.17.5) --- updated-dependencies: - dependency-name: github.com/lmittmann/w3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ethereum-optimism#14035) * op-challenger: Support downloading prestates with a specific filename. Allows running the latest builds published from develop automatically. * Update test * Log information on the state used.
* feat(devnet-sdk): expose minimal test interface * feat(devnet-sdk): basic infrastructure for mini test Co-authored-by: Jan Nanista <jan@oplabs.co> * feat(devnet-sdk): implemented system * test(interop): new mini test to validate framework * test(interop): improve mini test * fix(devnet-sdk): improve cnx management * fix(devnet-sdk): use big.Int * test(interop): add constraints * fix(devnet-sdk): fix tests * fix(devnet-testing): use pointer receivers consistently * fix(devnet-testing): remove unnecessary ContractAddress * fix(devnet-testing): remove unnecessary NewBalanceFromFloat * fix: cosmetic change to interop smoke test * feat(devnet-sdk): proper interface-backed implementation * feat(devnet-testing): testing the tests * feat(devnet-testing): interface cleanup * fix: remove obsolete Registry definition * fix: address review comments - add explicit interface checks (and remove superfluous interface) - add tests for Balance type --------- Co-authored-by: Jan Nanista <jan@oplabs.co> Co-authored-by: Stefano Charissis <stefano@oplabs.co>
…m-optimism#14078) Ensures the build fails if it is not available or has non-zero exit code rather than just checking for unsupported op codes in the error message.
* op-program: Write tx/receipts trie nodes to kv * op-program: Make trie node storage optional in client
…imism#14087) There's a nonce bug in the VM somewhere. This PR works around it and update these deployments to be deterministic. I'll investigate the bug separately.
…imism#13870) * WIP sketch out change in calldata calculation if l1 activated EIP-7623 * infer l1 Pectra activation from nullity of header.requestsHash pass this down to the TxData method so it can make an informed decision on DA type * add godoc * refactor and add unit test * tweak godoc * use much larger / more representative values in test * don't forget version byte * add another unit test * fix bug * typos * typo * make e2e test handle pectra * tweak * unit tests for DA switching cover L1 Pectra active and inactive * prefer isPectra = true in tests generally * tighten up test params * Wire up Prague Activation time in L1 genesis * run da switching test on holocene and activate prague at genesis with HoloceneSystemConfig * fix op-e2e fakepos to handle prague fork on L1 * update e2e tests to activate prague if they activate cancun * Revert "update e2e tests to activate prague if they activate cancun" This reverts commit f626d8d. * only activate prague in AutoDA test for now * default to no Prague * increase numTxs * fix godoc
This commit removes an e2e test that covers the custom gas token feature. Keeping this around will just result in extra maintenance overhead that is not necessary. Useful alongside: - ethereum-optimism#13603 - ethereum-optimism#13921 for maintaining a patch that contains custom gas token. It should be easy to bring this back in the future if necessary
* Start on Invalidator. * tests: TestCrossUnsafeReorg. * cleanup reorg tests. * first shot at cross-safe reorg. * cleanup some code. * make reorg test not use internal dbs directly. * move reorg tests to invalidator package. * remove stray code. * make reorg tests use Invalidator events. * Start refactor and cleanup. * tests * tweak: Use BlockID in Rewind events. * tweak: Signal all chain rewind on L1 reorg. * tweak: Use block height only to signal where to start checking for rewind. * lint and some small refactoring. * Create rewinder as soon as we create backend. * cleanup: Remove old code. * tweak: Update component name. * cleanup: remove stray code. * tweak: Tighten up L1 reorg detection. * cleanup: Remove stray code. * tweak: Don't rewind Unsafe chain past LocalSafe head. * tweak: Fix wrapped errors in db update helpers. * tweak: Make min block getter more clear. * tweak: Register rewinder events directly. * twweak: Update L1 same-block signal log. * fix: Don't return early if we've missed an L1 block. * refactor: Track L1 tip as a BlockID instead of separate height and hash. * tweak: Add warning when failing to find a common block and falling back to finalized. * tweak: Cleanup don't-rewind-past-finalized check. * refactor: L1 reorgs, V2. * starting on new unsafe rewinding. * fix: Use CrossSafe in node reset call. * cleanup: Remove old rewind code. * fix: L1 block traversal during common ancestor search. * tests: Update tests for refactored rewinder. * tweak: Make Unsafe rewind walkback up to finalized block. * tests: add L2 rewind walkback test. * refactor: Remove SyncNodes/L2 nodes from Rewinder. * tests,fix: Add CrossSafe to synnode mockBackend. * tests,fix: Correctly setup TestNoRewindNeeded. * cleanup: Remove old rewind code. * cleanup: Remove unused interface method. * refactor: In L1 rewinds, check Local DB first. * fix: Use correct LocalSafe to L1 resolution. * tests: Add test for L1 reorg that affects only local and not cross blocks. * tweak: Make work without finalized blocks. * tweak: Don't use finalized blocks in rewind test. * twweak: Only check hashes in L1 onLatest sameness check. * run ci * tweak: Don't reset logs in L1 reorg. * fix: Unsafe reorg common ancestor finding. * tests: Fix TestRewindL2WalkBack. * op-supervisor: fix L1-reorg handling --------- Co-authored-by: protolambda <proto@protolambda.com>
* feat: Remove mips64 and updates to MTCannon * chore: Unfreeze opcm * chore: update semver-lock * feat: update snapshots * fix: unused imports * feat: bump semvers * semver-lock * feat: updates to op-deployer * fix test --------- Co-authored-by: Matthew Slipper <me@matthewslipper.com>
…thereum-optimism#14114) * cannon: Update SLL(V) to mask out upper bits before sign extending * cannon: Run semver lock * cannon: Update MIPS64.sol version to 1.0.0-beta.1 * cannon: Remove MIPS64 from code freeze list * cannon: Follow go naming convention for U32Mask
* op-challenger: Check local safe heads to return invalid hash at the first chain that is unsafe. * Update interop tests and enable challenger tests.
…ism#14111) * op-batcher: do not log error from network call when shutting down Also prefer local context to global one. We can detect if the RPC call failed due to the context being cancelled, so we can avoid any more work in this function (including the bit that logs an error). * avoid error logging expected error * define a context for the txmgr.Queue and cancel during shutdown this should speed up shutdown, allowing goroutines to exit more quickly
…#13853) * op-node: Add --l2.engine-rpc-timeout flag Add a new --l2.engine-rpc-timeout flag to configure the timeout duration for L2 Engine RPC calls. This allows for more flexible and explicit control over RPC call timeouts. * op-service: Remove redundant timeout from engine client
…ism#13927) Bumps [github.com/cockroachdb/pebble](https://github.com/cockroachdb/pebble) from 1.1.3 to 1.1.4. - [Release notes](https://github.com/cockroachdb/pebble/releases) - [Commits](cockroachdb/pebble@v1.1.3...v1.1.4) --- updated-dependencies: - dependency-name: github.com/cockroachdb/pebble dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#13122) Signed-off-by: jsvisa <delweng@gmail.com>
hexshire
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.