Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove unused arg from OPCM upgrade tests #14113

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

maurelian
Copy link
Contributor

Description

Removes an argument which was added unnecessarily in #13814.

@maurelian maurelian requested a review from a team as a code owner February 3, 2025 18:49
Copy link
Contributor

@ControlCplusControlV ControlCplusControlV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: - sidenote do we not have CI to detect things like this?

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.09%. Comparing base (66fea80) to head (9d2509f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14113      +/-   ##
===========================================
- Coverage    46.42%   45.09%   -1.33%     
===========================================
  Files          994      937      -57     
  Lines        84020    79352    -4668     
===========================================
- Hits         39008    35787    -3221     
+ Misses       42062    40796    -1266     
+ Partials      2950     2769     -181     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 65 files with indirect coverage changes

@maurelian maurelian added this pull request to the merge queue Feb 3, 2025
@maurelian
Copy link
Contributor Author

@ControlCplusControlV

:shipit: - sidenote do we not have CI to detect things like this?

it's a bit of a tricky case to detect, because the arg wasn't entirely unused, it just didn't matter what it was set to.

open to a suggested semgrep rule

Merged via the queue into develop with commit b496924 Feb 3, 2025
45 checks passed
@maurelian maurelian deleted the maur/rm-arg branch February 3, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants