Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm-runner: Add extra logging when selecting L1 head #14061

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

ajsutton
Copy link
Contributor

Description

Add extra logging to assist with tracking down some weird l1 head is 0 errors we keep getting in vm-runner.

@ajsutton ajsutton requested review from a team as code owners January 30, 2025 03:26
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 42.06%. Comparing base (7b53454) to head (4a91ae5).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
op-challenger/runner/runner.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14061      +/-   ##
===========================================
- Coverage    46.44%   42.06%   -4.38%     
===========================================
  Files          989      824     -165     
  Lines        83610    74303    -9307     
===========================================
- Hits         38834    31259    -7575     
+ Misses       41848    40283    -1565     
+ Partials      2928     2761     -167     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-challenger/runner/runner.go 0.00% <0.00%> (ø)

... and 174 files with indirect coverage changes

@ajsutton ajsutton added this pull request to the merge queue Jan 30, 2025
Merged via the queue into develop with commit e08bd0f Jan 30, 2025
45 checks passed
@ajsutton ajsutton deleted the aj/vm-runner-logging branch January 30, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants