fix: issue with helpers.display SCSS mixin

[nmerget]

Proposed changes

• fix: issue with helpers.display SCSS mixin only use it on top level component
• fix: issue with hide-animation for drawer

Types of changes

• Bugfix (non-breaking change that fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (improvements to existing components or architectural decisions)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-helpers-display

[changeset-bot]

🦋 Changeset detected

Latest commit: 6e4e678

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@db-ux/core-components	Patch
@db-ux/ngx-core-components	Patch
@db-ux/react-core-components	Patch
@db-ux/wc-core-components	Patch
@db-ux/v-core-components	Patch
@db-ux/core-foundations	Patch
@db-ux/core-stylelint	Patch
@db-ux/core-migration	Patch
@db-ux/agent-cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mfranzke]

fix: issue with helpers.display SCSS mixin only use it on top level component

@nmerget could you please add some more information on why we should only use that SCSS mixin for declarations on the top-level component element ?

[nmerget]

fix: issue with helpers.display SCSS mixin only use it on top level component

@nmerget could you please add some more information on why we should only use that SCSS mixin for declarations on the top-level component element ?

It adds a :not(hidden) selector to child classes. It is not necessary and for something like the drawer it breaks even the component

[mfranzke]

It adds a :not(hidden) selector to child classes. It is not necessary

Why isn't it necessary to have this implemented for child elements of components as well ? A developer might set the hidden-HTML-attribute on nearly all HTML elements (even though that there might be edge cases like the drawer that you've identified).