Skip to content

fix: issue with helpers.display SCSS mixin #5350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmerget merged 2 commits into from
Oct 22, 2025
Merged

fix: issue with helpers.display SCSS mixin #5350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53f6665
fix: issue with helpers.display method - only use it on top level com…
nmerget Oct 22, 2025
6e4e678
Merge branch 'main' into fix-helpers-display
mfranzke Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/wide-ducks-juggle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@db-ux/core-components": patch
"@db-ux/ngx-core-components": patch
"@db-ux/react-core-components": patch
"@db-ux/wc-core-components": patch
"@db-ux/v-core-components": patch
---

fix: hide-animation for drawer
4 changes: 2 additions & 2 deletions packages/components/src/components/brand/brand.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
@use "@db-ux/core-foundations/build/styles/variables";
@use "@db-ux/core-foundations/build/styles/colors";
@use "@db-ux/core-foundations/build/styles/fonts";
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "@db-ux/core-foundations/build/styles/helpers";

.db-brand {
@extend %db-overwrite-font-size-md;
@include display.display(flex);
@include helpers.display(flex);

gap: variables.$db-spacing-fixed-sm;
align-items: center;
Expand Down
6 changes: 2 additions & 4 deletions packages/components/src/components/custom-select-list/custom-select-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use "@db-ux/core-foundations/build/styles/variables";
@use "../../styles/internal/form-components";
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "@db-ux/core-foundations/build/styles/helpers";

.db-custom-select-list {
all: unset;
Expand All @@ -27,9 +27,7 @@

> ul {
all: unset;

@include display.display(flex);

display: flex;
flex-direction: column;

&:has(span) {
Expand Down
9 changes: 5 additions & 4 deletions packages/components/src/components/drawer/drawer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ $spacings: (
.db-drawer-container {
@extend %direction-right;
@extend %spacing-drawer;
@include helpers.display(flex);

display: flex;
flex-direction: column;
background-color: colors.$db-adaptive-bg-basic-level-1-default;
block-size: 100%;
Expand Down Expand Up @@ -204,7 +204,8 @@ $spacings: (
}

.db-drawer-header {
@include helpers.display(none);
display: none;

@include helpers.divider("bottom");

.db-drawer-header-text {
Expand All @@ -223,7 +224,7 @@ $spacings: (

&:has(.button-close-drawer),
&:has(:not(.db-drawer-header-text:empty)) {
@include helpers.display(flex);
display: flex;
}
}
}
Expand All @@ -237,7 +238,7 @@ $spacings: (
background-color: transparent;

&[open] {
@include helpers.display(flex);
display: flex;
}

&:not([data-direction]),
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/icon/icon.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
@use "@db-ux/core-foundations/build/styles/icons";
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "@db-ux/core-foundations/build/styles/helpers";

.db-icon {
@include icons.is-icon-text-replace;

/* Safari hack */
@supports (-webkit-hyphens: none) {
@include display.display(inline-block);
@include helpers.display(inline-block);

&::before {
block-size: auto;
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/infotext/infotext.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
@use "sass:map";
@use "@db-ux/core-foundations/build/styles/fonts";
@use "@db-ux/core-foundations/build/styles/variables";
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "@db-ux/core-foundations/build/styles/helpers";
@use "@db-ux/core-foundations/build/styles/colors";
@use "@db-ux/core-foundations/build/styles/icons";

.db-infotext {
--db-icon-margin-end: #{variables.$db-spacing-fixed-2xs};

@extend %db-overwrite-font-size-sm;
@include display.display(flex);
@include helpers.display(flex);

@include icons.has-no-icon {
@include icons.to-filled-icon;
Expand Down
7 changes: 3 additions & 4 deletions packages/components/src/components/navigation/navigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@use "@db-ux/core-foundations/build/styles/variables";
@use "@db-ux/core-foundations/build/styles/screen-sizes";
@use "../../styles/internal/component";
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "@db-ux/core-foundations/build/styles/helpers";
@use "../../styles/internal/form-components";
@use "../../styles/internal/db-puls";

Expand All @@ -15,8 +15,7 @@
}

> menu {
@include display.display(flex);

display: flex;
flex-direction: column;
padding: 0;
margin: 0;
Expand Down Expand Up @@ -102,7 +101,7 @@
&[data-force-close="true"] {
> menu menu {
@include screen-sizes.screen("md") {
@include display.display(none);
@include helpers.display(none);
}
}
}
Expand Down
4 changes: 1 addition & 3 deletions packages/components/src/components/notification/notification-grid-non-overlay.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@use "@db-ux/core-foundations/build/styles/helpers/display";

%grid-layout-variant-not-overlay {
span {
@include display.display(none);
display: none;
}

// has link
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/notification/notification.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@use "sass:map";
@use "@db-ux/core-foundations/build/styles/density";
@use "@db-ux/core-foundations/build/styles/variables";
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "@db-ux/core-foundations/build/styles/helpers";
@use "@db-ux/core-foundations/build/styles/colors";
@use "@db-ux/core-foundations/build/styles/icons";
@use "@db-ux/core-foundations/build/styles/screen-sizes";
Expand All @@ -28,7 +28,7 @@
@extend %component-border;
@extend %grid-layout-default;
@extend %ugly-line-height-workarounds;
@include display.display(grid);
@include helpers.display(grid);

padding: variables.$db-spacing-fixed-md;
gap: variables.$db-spacing-fixed-xs variables.$db-spacing-fixed-md;
Expand Down
8 changes: 4 additions & 4 deletions packages/components/src/components/page/page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use "@db-ux/core-foundations/build/styles/variables";
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "@db-ux/core-foundations/build/styles/helpers";

.db-page-document {
block-size: 100%;
Expand All @@ -8,7 +8,7 @@

@mixin header-footer-style {
> :is(.db-header, .db-footer, header, footer) {
@include display.display(flex);
@include helpers.display(flex);

flex: 0 1 auto;
flex-grow: 0;
Expand Down Expand Up @@ -36,7 +36,7 @@
block-size: 100%;
min-block-size: 100%;

@include display.display(flex);
@include helpers.display(flex);

flex-direction: column;

Expand All @@ -46,7 +46,7 @@
}

> .db-main {
@include display.display(flex);
@include helpers.display(flex);

flex-direction: column;
overflow: auto;
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/popover/popover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
@use "@db-ux/core-foundations/build/styles/variables";
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "@db-ux/core-foundations/build/styles/helpers";
@use "../../styles/internal/popover-component";
@use "../../styles/internal/component";

.db-popover {
position: relative;

@include display.display(flex);
@include helpers.display(flex);

block-size: fit-content;
inline-size: fit-content;
Expand Down
3 changes: 1 addition & 2 deletions packages/components/src/components/select/select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
@use "../../styles/internal/form-components";
@use "../../styles/internal/component";
@use "../../styles/internal/select-components";
@use "@db-ux/core-foundations/build/styles/helpers/display";

.db-select-placeholder {
@extend %select-absolute-placeholder;
Expand Down Expand Up @@ -47,7 +46,7 @@

&:has(> select option:checked:not(.placeholder)) {
[id$="-placeholder"] {
@include display.display(none);
display: none;
}
}
}
3 changes: 1 addition & 2 deletions packages/components/src/components/tab-list/tab-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
@use "@db-ux/core-foundations/build/styles/variables";
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "../../styles/internal/scrollbar";

.db-tab-list {
Expand All @@ -9,8 +8,8 @@

> ul {
@extend %scrollbar;
@include display.display(flex);

display: flex;
gap: variables.$db-spacing-fixed-sm;
scroll-behavior: smooth;
padding: 0;
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/tab-panel/tab-panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use "@db-ux/core-foundations/build/styles/variables";
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "@db-ux/core-foundations/build/styles/helpers";

.db-tab-panel {
@include display.display(none);
@include helpers.display(none);
}
8 changes: 4 additions & 4 deletions packages/components/src/components/tabs/tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@use "@db-ux/core-foundations/build/styles/colors";
@use "../../styles/internal/form-components";
@use "../../styles/internal/db-puls";
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "@db-ux/core-foundations/build/styles/helpers";

$max-tabs: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10];

Expand All @@ -13,7 +13,7 @@ $max-tabs: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
&:has([id$="-tab-#{$index}"]:checked) {
~ dbtabpanel > [id$="-tab-panel-#{$index}"],
~ db-tab-panel > [id$="-tab-panel-#{$index}"] {
@include display.display(block);
@include helpers.display(block);
}
}
}
Expand Down Expand Up @@ -75,7 +75,7 @@ $max-tabs: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
$db-tabs-z-index-button: 22;

@extend %angular-workaround;
@include display.display(flex);
@include helpers.display(flex);

inline-size: 100%;
position: relative;
Expand All @@ -91,7 +91,7 @@ $max-tabs: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
@each $index in $max-tabs {
&:has([id$="-tab-#{$index}"]:checked)
~ [id$="-tab-panel-#{$index}"] {
@include display.display(block);
@include helpers.display(block);
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/styles/internal/_button-components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
@use "@db-ux/core-foundations/build/styles/helpers/display";
@use "@db-ux/core-foundations/build/styles/helpers";

%default-button {
font-weight: 700;
white-space: nowrap; // we don't want to break buttons
justify-content: center;
text-align: center;

@include display.display(inline-flex);
@include helpers.display(inline-flex);

align-items: center; // Centering the content vertically and horizontally
vertical-align: top; // Alignment of inline-flex buttons with different content
Expand Down