fix: prevent cropped icons in webkit #5261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not cropped in webkit closes #5247
this is needed since otherwise when running `npm run changeset`, will error with: > The package or glob expression "@db-ux/core-web" is specified in the > `ignore` option but it is not found in the project. >You may have misspelled the package name or provided an invalid glob expression
github-project-automation
bot
moved this to 🏗 In progress
in UX Engineering Team Backlog
🦋 Changeset detectedLatest commit: 04aae5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
📕documentation
d-koppenhagen
commented
Oct 15, 2025
mfranzke
reviewed
Oct 15, 2025
Co-authored-by: Maximilian Franzke <[email protected]>
d-koppenhagen
changed the title
min-inline-size and max-inline-size to ensure icons are not cropped in webkit
d-koppenhagen
commented
Oct 15, 2025
mfranzke
moved this from 🏗 In progress
to 👀 Actively In Review
in UX Engineering Team Backlog
mfranzke
previously approved these changes
Oct 15, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mfranzke
approved these changes
Oct 15, 2025
github-project-automation
bot
moved this from 👀 Actively In Review
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fixes #5247
Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/5247-fix-cropped-icons-webkit