Skip to content

fix: prevent cropped icons in webkit #5261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfranzke merged 10 commits into from
Oct 15, 2025
Merged

fix: prevent cropped icons in webkit #5261

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b2d7a7f
fix: set `min-inline-size` and `max-inline-size` to ensure icons are …
d-koppenhagen Oct 15, 2025
2606e92
chore: remove `@db-ux/core-web` from changeset config
d-koppenhagen Oct 15, 2025
c600a48
chore: changesets
d-koppenhagen Oct 15, 2025
ea4f709
fix: use correct version type `patch`
d-koppenhagen Oct 15, 2025
556044c
Update packages/foundations/scss/icons/_icon-helpers.scss
d-koppenhagen Oct 15, 2025
f6eb0b0
Update .changeset/young-doors-act.md
d-koppenhagen Oct 15, 2025
5fe0d99
Merge branch 'main' into 5247-fix-cropped-icons-webkit
mfranzke Oct 15, 2025
f1e2ac9
Fix typo in aspect-ratio property
mfranzke Oct 15, 2025
e1eb717
Update _icon-helpers.scss
mfranzke Oct 15, 2025
04aae5d
auto update snapshots (#5265)
github-actions[bot] Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,19 @@
"@db-ux/agent-cli"
]
],
"ignore": ["scripts", "@db-ux/core-web", "@db-ux/docs", "@db-ux/e2e", "angular-showcase", "angular-ssr-showcase", "next-showcase", "nuxt-showcase", "patternhub", "react-showcase", "stencil-showcase", "vue-showcase"],
"ignore": [
"scripts",
"@db-ux/docs",
"@db-ux/e2e",
"angular-showcase",
"angular-ssr-showcase",
"next-showcase",
"nuxt-showcase",
"patternhub",
"react-showcase",
"stencil-showcase",
"vue-showcase"
],
"linked": [],
"access": "public",
"baseBranch": "origin/main",
Expand Down
5 changes: 5 additions & 0 deletions .changeset/young-doors-act.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@db-ux/core-foundations": patch
---

fix: set `min-inline-size` and `max-inline-size` to ensure icons are not cropped in webkit
3 changes: 2 additions & 1 deletion packages/foundations/scss/icons/_icon-helpers.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ $default-icon-font-size: var(--db-icon-font-size, #{$default-icon-size-rem});
overflow: clip;
vertical-align: var(--db-icon-vertical-align, middle);
block-size: $default-icon-font-size;
inline-size: $default-icon-font-size;
aspect-radio: 1 / 1;
flex-shrink: 0

@include icon-content($default-icon-content); // TODO: ONLY FOR data-icon

Expand Down
Loading