merge #36
Merged
merge #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Network: Remove built in nagle algo and fully go async * Fix compilation due to printf error * Fix hang on shutdown * Add changes requested in comments * Make last session key update in sequence sync to avoid race condition with db
Mistress Nagmara 9500 (npc_mistress_nagmara) Private Rocknot 9503 (npc_rocknot) cmangos/issues#3529
* Use item 10587 "Goblin Bomb Dispenser" - casts spell 23134 "Goblin Bomb" * 10% chance to malfunction with spell 13261 "Malfunction Explosion or 90% chance to proceed with spell 13258 "Summon Goblin Bomb" * Creature 8937 "Pet Bomb" is summoned - level is player's engineering skill divided by 5 * Pet Bomb has aura 13260 "Pet Bomb Passive" on spawn - triggers 13259 "Explosion" on successful melee hit cmangos/issues#637
… confirmed Original vmangos authors: @balakethelock @ratkosrb
…ket, load and item_text width
This also fixes a GCC/clang 'unused parameter' [-Wunused-parameter] compiler warning.
…CAST_SPELL to pass nullptr target
…s2::NO_INTERRUPT_SCHOOL_COOLDOWN
Wotlk + @ratkosrb authorship for noticing
Also ports swiftmend check to spell script to remove merge conflict
* [Quest] rework Missing in Action quest using new systems * add changes requested in comments
* Config: Implement config override with env vars Implement overriding of configuration from the .conf file with environment variables. Environment variables keys are autogenerated based on the keys defined in .conf file. Usage example: $ export CM_DATA_DIR=/usr $ CM_WORLD_SERVER_PORT=8080 ./mangosd * Update env var key format and encapsulated env loading logic. The new env key format: Mangosd_Rate_Health Mangosd_DataDir * Add suggestions from code review. * Add missing includes.
Close cmangos/mangos-wotlk#508 Credit @insunaa for the general idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Proof
Issues
How2Test
Todo / Checklist