merge (#36)

* Remove gameobject los temp fix for playerbots

* Chat: Fix npc info parts not working with dynguid

* StringId: Add const qualifiers to params to enable passing const strings

* SpawnGroup: Add errors for using same type dbGuid twice

* Spell/Unit: Disable charge proccing in proc system for spellmods

Closes cmangos/issues#3648

* Network: Remove built in nagle algo and fully go async (#653)

* Network: Remove built in nagle algo and fully go async

* Fix compilation due to printf error

* Fix hang on shutdown

* Add changes requested in comments

* Make last session key update in sequence sync to avoid race condition with db

* Realm/Core: Improve start script for mangosd and add realmd one

* Realmd: Remove leftover printf

* BRD: Adjust motion type used by Nagmara & Rocknot

Mistress Nagmara 9500 (npc_mistress_nagmara)
Private Rocknot 9503 (npc_rocknot)

cmangos/issues#3529

* Realmd/Core: Adjust username length to proper max length allowed during creation

* Fix compilation errors

* Spell/Engineering: Goblin Bomb Dispenser

* Use item 10587 "Goblin Bomb Dispenser" - casts spell 23134 "Goblin Bomb"
* 10% chance to malfunction with spell 13261 "Malfunction Explosion or 90% chance to proceed with spell 13258 "Summon Goblin Bomb"
* Creature 8937 "Pet Bomb" is summoned - level is player's engineering skill divided by 5
* Pet Bomb has aura 13260 "Pet Bomb Passive" on spawn - triggers 13259 "Explosion" on successful melee hit

cmangos/issues#637

* Spell: Reimplement SPELL_ATTR_SCALES_WITH_CREATURE_LEVEL using CLS as confirmed

Original vmangos authors:

@balakethelock
@ratkosrb

* Spell: Safeguard go use which has lockId and should be used by spell

* Add couple safeguards to ProcessIncomingData against crashes

cmangos/issues#3672

* Item: Add check against RequiredLevel for lootable items

* Gameobject: Port GetSpellForLock from tbc

* [z2819] Item: Adjust itemTextId in item_instance to correspond to packet, load and item_text width

* Creature: Implement CreatureLinkingAggroDelay

* Network: Add missing error return clause to WorldSocket::ProcessIncomingData

* Network: Do not disconnect session when packet cooldown is triggered

* Creature: Fix crash due to missing enemy safeguard

* AI: Disable assistance call for critters

* Scripts: Fix SCRIPT_COMMAND_OPEN_DOOR not working with dynguid

* Chat: Implement .worldstate set X Y

* PeriodicTriggerData: fix member initializer list.

This also fixes a GCC/clang 'unused parameter' [-Wunused-parameter]
compiler warning.

* Fix memory leak, leaking a single script.

* Network: Add a couple missing captures

* Scripts: Implement SCRIPT_FLAG_COMMAND_ADDITIONAL for SCRIPT_COMMAND_CAST_SPELL to pass nullptr target

* Network: Rework reconnection case to fix slow cpu race conditions
cmangos/issues#3676

* Adjust CreatureFamilyAssistanceRadius being too big

* [z2820] Auth: Adjust joindate to be datetime

* Network: Add back error handling from old code for packet header in mangosd

* Tools/MMaps: Fixed a suspicious bitwise condition.

ProjectSkyfire/SkyFire_548@89063ad

* Creature: Reimplement Creature::LockOutSpells with CreatureStaticFlags2::NO_INTERRUPT_SCHOOL_COOLDOWN

* Player: Add afk kick after 15 minutes back in

* Network: Remove redundant payload of SMSG_AUTH_CHALLENGE

Wotlk +

@ratkosrb authorship for noticing

* Spell: Add flag usage to SMSG_SPELL_COOLDOWN instead of random value

* Relations: Implement caster and target flag skip from attributes

* Spell: Implement usage of restriction skip attributes for basic things
Also ports swiftmend check to spell script to remove merge conflict

* fix ProcSystemArguments constructor arg mismatch

* [Quest] rework Missing in Action quest using new systems (#660)

* [Quest] rework Missing in Action quest using new systems

* add changes requested in comments

* SpawnGroup: Implement CREATURE_GROUP_FORMATION_MIRRORING

* Config: Implement config override with env vars (cmangos#502)

* Config: Implement config override with env vars

Implement overriding of configuration from the .conf file with environment variables.
Environment variables keys are autogenerated based on the keys defined in .conf file.
Usage example:
$ export CM_DATA_DIR=/usr
$ CM_WORLD_SERVER_PORT=8080 ./mangosd

* Update env var key format and encapsulated env loading logic.

The new env key format:
Mangosd_Rate_Health
Mangosd_DataDir

* Add suggestions from code review.

* Add missing includes.

* Pet: Tryfix double unsummon crash due to visibility

Close cmangos/mangos-wotlk#508

Credit @insunaa for the general idea

* [Quest] modernize defias brotherhood escort quest
Closes cmangos/mangos-tbc#662

* [Quest] modernize 'Protect the Shipment' escort quest
Closes cmangos/mangos-tbc#663

* G3D: Extend Support for new MacOS Versions (+Apple Silicon)

* Pet: Fix compilation for pch on linux

* G3D: Fix MacOS/Apple Silicon compile

* Playerbots: Fix compilation issue

---------

Co-authored-by: killerwife <[email protected]>
Co-authored-by: MantisLord <[email protected]>
Co-authored-by: Fonix <[email protected]>
Co-authored-by: robinsch <[email protected]>
Co-authored-by: evil-at-wow <[email protected]>
Co-authored-by: cdkr <[email protected]>
Co-authored-by: _daanieL <[email protected]>
Co-authored-by: Anton Popovichenko <[email protected]>
Co-authored-by: insunaa <[email protected]>