Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Create databricks labs ucx lint-local-code command #1541

Closed
1 task done
Tracked by #1085
nfx opened this issue Apr 24, 2024 · 1 comment · Fixed by #1710
Closed
1 task done
Tracked by #1085

[FEATURE]: Create databricks labs ucx lint-local-code command #1541

nfx opened this issue Apr 24, 2024 · 1 comment · Fixed by #1710
Assignees
@ericvergnaud
Labels
feat/cli CLI commands feat/migration-index mapping of databases to catalog or potentially other databases migrate/code Abstract Syntax Trees and other dark magic migrate/jobs Step 5 - Upgrading Jobs for External Tables

Comments

@nfx
Copy link
Collaborator

nfx commented Apr 24, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

we need to lint local python code for problems in notebooks and other python files

Proposed Solution

Create databricks labs ucx lint-local-code command

Additional Context

No response
@nfx nfx added feat/migration-index mapping of databases to catalog or potentially other databases migrate/jobs Step 5 - Upgrading Jobs for External Tables feat/cli CLI commands migrate/code Abstract Syntax Trees and other dark magic labels Apr 24, 2024
@nfx nfx added this to UCX Apr 24, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Apr 24, 2024
@nfx nfx mentioned this issue Apr 24, 2024
Open
26 tasks
@nfx nfx moved this from Triage to Active Backlog in UCX Apr 24, 2024
@jimidle jimidle mentioned this issue Apr 30, 2024
Closed
11 tasks
@nfx nfx mentioned this issue May 3, 2024
Merged
@nfx
Copy link
Collaborator Author

nfx commented May 6, 2024

use FileLinter from #1613

@nfx nfx assigned ericvergnaud and unassigned jimidle May 6, 2024
nfx added a commit that referenced this issue May 7, 2024
@nfx
Added baseline for workflow linter (#1613)
1ae345a 
```mermaid
flowchart TD
    job -->|has many| job_task
    job_task -.-> notebook_task
    job_task -.-> wheel_task 

    job -.-> git_source

    job_task -.->|execute on| interactive_cluster
    interactive_cluster -.-> library

    job_task -.-> library
    library -.-> wheel_on_dbfs
    library -.-> wheel_on_wsfs
    library -.-> wheel_on_volumes
    library -.-> egg_on_dbfs
    library -.-> egg_on_wsfs
    library -.-> pypi
    wheel_task -.-> wheel_on_dbfs
    wheel_task -.-> wheel_on_wsfs

    wheel_on_dbfs -.-> python_file
    wheel_on_wsfs -.-> python_file
    egg_on_dbfs -.-> python_file
    egg_on_wsfs -.-> python_file
    pypi -.-> python_file
    wsfs_file -.-> python_file
    python_file -.->|import| python_file
    notebook_task -.-> notebook
    notebook -.->|import| python_file
    notebook -.->|can run| notebook

    job_task -.-> dependency_graph
    python_file --> dependency_graph
    notebook --> dependency_graph

    git_source -.-> python_file
    git_source -.-> notebook
    lint_local_code_cli --> dependency_graph

    workflow_linter --> dependency_graph
    workflow_linter -.-> job_problems
    dependency_graph -.-> job_problems
    job_problems -.->|viz| redash_dashboard
```

This PR adds baseline for linting workflows

Related to:
- #1542 
- #1541
- #1540
- #1539
- #1382
- #1204
- #1203
- #1085

closes #1559
closes #1468
closes #1286
@ericvergnaud ericvergnaud mentioned this issue May 17, 2024
Merged
11 tasks
@nfx nfx closed this as completed in #1710 May 24, 2024
@github-project-automation github-project-automation bot moved this from Active Backlog to Archive in UCX May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericvergnaud ericvergnaud

Labels
feat/cli CLI commands feat/migration-index mapping of databases to catalog or potentially other databases migrate/code Abstract Syntax Trees and other dark magic migrate/jobs Step 5 - Upgrading Jobs for External Tables
Projects
UCX
Archived in project
Milestone
No milestone
3 participants
@nfx @jimidle @ericvergnaud