Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: When detecting compatibility issues, check against current DB runtime version #1382

Closed
1 task done
Tracked by #1202
ericvergnaud opened this issue Apr 12, 2024 · 2 comments
Closed
1 task done
Tracked by #1202

[FEATURE]: When detecting compatibility issues, check against current DB runtime version #1382

ericvergnaud opened this issue Apr 12, 2024 · 2 comments
Labels
migrate/code Abstract Syntax Trees and other dark magic migrate/jobs Step 5 - Upgrading Jobs for External Tables migrate/python Pull requests that update Python code

Comments

@ericvergnaud
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

Compatibility issues vary depending on package version and DB runtime version.
There is a need to check compatibility with given version to avoid false positives (incorrect Advice) and false negatives (missing Advice)

Proposed Solution

Read current DB runtime version, and installed package version, and use them in Whitelist

Additional Context

sub-ticker of #1202
@ericvergnaud ericvergnaud added enhancement New feature or request needs-triage labels Apr 12, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Apr 12, 2024
@ericvergnaud ericvergnaud mentioned this issue Apr 12, 2024
Closed
18 tasks
@nfx nfx added migrate/jobs Step 5 - Upgrading Jobs for External Tables migrate/code Abstract Syntax Trees and other dark magic migrate/python Pull requests that update Python code and removed enhancement New feature or request needs-triage labels Apr 22, 2024
@nfx nfx mentioned this issue Apr 22, 2024
Open
26 tasks
@nfx
Copy link
Collaborator

nfx commented Apr 24, 2024

Should be a field in the CurrentSessionState

@nfx nfx moved this from Triage to Active Backlog in UCX May 2, 2024
@nfx nfx mentioned this issue May 3, 2024
Merged
@ericvergnaud
Copy link
Contributor Author

Duplicate of #1527

@ericvergnaud ericvergnaud marked this as a duplicate of #1527 May 6, 2024
@github-project-automation github-project-automation bot moved this from Active Backlog to Archive in UCX May 6, 2024
nfx added a commit that referenced this issue May 7, 2024
@nfx
Added baseline for workflow linter (#1613)
1ae345a 
```mermaid
flowchart TD
    job -->|has many| job_task
    job_task -.-> notebook_task
    job_task -.-> wheel_task 

    job -.-> git_source

    job_task -.->|execute on| interactive_cluster
    interactive_cluster -.-> library

    job_task -.-> library
    library -.-> wheel_on_dbfs
    library -.-> wheel_on_wsfs
    library -.-> wheel_on_volumes
    library -.-> egg_on_dbfs
    library -.-> egg_on_wsfs
    library -.-> pypi
    wheel_task -.-> wheel_on_dbfs
    wheel_task -.-> wheel_on_wsfs

    wheel_on_dbfs -.-> python_file
    wheel_on_wsfs -.-> python_file
    egg_on_dbfs -.-> python_file
    egg_on_wsfs -.-> python_file
    pypi -.-> python_file
    wsfs_file -.-> python_file
    python_file -.->|import| python_file
    notebook_task -.-> notebook
    notebook -.->|import| python_file
    notebook -.->|can run| notebook

    job_task -.-> dependency_graph
    python_file --> dependency_graph
    notebook --> dependency_graph

    git_source -.-> python_file
    git_source -.-> notebook
    lint_local_code_cli --> dependency_graph

    workflow_linter --> dependency_graph
    workflow_linter -.-> job_problems
    dependency_graph -.-> job_problems
    job_problems -.->|viz| redash_dashboard
```

This PR adds baseline for linting workflows

Related to:
- #1542 
- #1541
- #1540
- #1539
- #1382
- #1204
- #1203
- #1085

closes #1559
closes #1468
closes #1286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
migrate/code Abstract Syntax Trees and other dark magic migrate/jobs Step 5 - Upgrading Jobs for External Tables migrate/python Pull requests that update Python code
Projects
UCX
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nfx @ericvergnaud