Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Report errors when building notebook dependency graph #1286

Closed
1 task done
Tracked by #1085
ericvergnaud opened this issue Apr 5, 2024 · 0 comments · Fixed by #1613
Closed
1 task done
Tracked by #1085

[FEATURE]: Report errors when building notebook dependency graph #1286

ericvergnaud opened this issue Apr 5, 2024 · 0 comments · Fixed by #1613
Assignees
@nfx
Labels
migrate/code Abstract Syntax Trees and other dark magic tech debt chores and design flaws

Comments

@ericvergnaud
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

Building notebook dependency graph requires:

  • traversing source code which may be flaky
  • locating notebooks which may be missing
    Encountered error should be reported

Proposed Solution

To be analyzed

Additional Context

This is a reminder, following implementation of #1200 #1201 and #1202
@ericvergnaud ericvergnaud added enhancement New feature or request needs-triage labels Apr 5, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Apr 5, 2024
@ericvergnaud ericvergnaud mentioned this issue Apr 9, 2024
Merged
nfx pushed a commit that referenced this issue Apr 10, 2024
@ericvergnaud @JCZuurmond
Integrate detection of notebook dependencies (#1338)
f704ac2 
## Changes
 - integrates dependency graph to NotebookMigrator

### Linked issues
#1204 
#1286 
#1326

---------

Co-authored-by: Cor <[email protected]>
@nfx nfx added tech debt chores and design flaws migrate/code Abstract Syntax Trees and other dark magic and removed enhancement New feature or request needs-triage labels Apr 22, 2024
@nfx nfx mentioned this issue Apr 22, 2024
Open
26 tasks
@nfx nfx moved this from Triage to Active Backlog in UCX May 2, 2024
@nfx nfx self-assigned this May 3, 2024
@nfx nfx mentioned this issue May 3, 2024
Merged
@nfx nfx closed this as completed in #1613 May 7, 2024
@nfx nfx closed this as completed in 1ae345a May 7, 2024
@github-project-automation github-project-automation bot moved this from Active Backlog to Archive in UCX May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfx nfx

Labels
migrate/code Abstract Syntax Trees and other dark magic tech debt chores and design flaws
Projects
UCX
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added baseline for workflow linter databrickslabs/ucx
2 participants
@nfx @ericvergnaud