Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Improve integration test comment #1035

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

hectorcast-db
Copy link
Contributor

Changes

Improve integration test comment

Tests

  • make test passing
  • make fmt applied
  • relevant integration tests applied

@hectorcast-db hectorcast-db added this pull request to the merge queue Sep 2, 2024
@hectorcast-db hectorcast-db removed this pull request from the merge queue due to a manual request Sep 2, 2024
@hectorcast-db hectorcast-db added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit 590d597 Sep 2, 2024
9 checks passed
@hectorcast-db hectorcast-db deleted the fix-message branch September 2, 2024 14:03
@databricks databricks deleted a comment from github-actions bot Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

Test status: completed

This check will be approved automatically on success.

Check URL: https://github.com/databricks/databricks-sdk-go/runs/29568506359

mgyucht added a commit that referenced this pull request Sep 4, 2024
### Bug Fixes

 * Fail fast when authenticating if host is not configured ([#1033](#1033)).
 * Improve non-JSON error handling ([#1031](#1031)).

### Internal Changes

 * Add TestAccCreateOboTokenOnAws to flaky test list ([#1029](#1029)).
 * Add workflows manage integration tests checks ([#1032](#1032)).
 * Fix TestMwsAccWorkspaces cleanup ([#1028](#1028)).
 * Improve integration test comment ([#1035](#1035)).
 * Temporary ignore Metastore test failures ([#1027](#1027)).
 * Update test to support new accounts ([#1026](#1026)).
 * Use statuses instead of checks ([#1036](#1036)).

### API Changes:

 * Added `RegenerateDashboard` method for [w.QualityMonitors](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#QualityMonitorsAPI) workspace-level service.
 * Added [catalog.RegenerateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardRequest) and [catalog.RegenerateDashboardResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardResponse).
 * Added [jobs.QueueDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetails), [jobs.QueueDetailsCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetailsCodeCode), [jobs.RunLifecycleStateV2State](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunLifecycleStateV2State), [jobs.RunStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunStatus), [jobs.TerminationCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationCodeCode), [jobs.TerminationDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationDetails) and [jobs.TerminationTypeType](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationTypeType).
 * Added `Status` field for [jobs.BaseRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun).
 * Added `Status` field for [jobs.RepairHistoryItem](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RepairHistoryItem).
 * Added `Status` field for [jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).
 * Added `Status` field for [jobs.RunTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunTask).
 * Added `MaxProvisionedThroughput` and `MinProvisionedThroughput` fields for [serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput).
 * Added `ColumnsToSync` field for [vectorsearch.DeltaSyncVectorIndexSpecRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch#DeltaSyncVectorIndexSpecRequest).
 * Changed `WorkloadSize` field for [serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput) to no longer be required.

OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
### Bug Fixes

* Fail fast when authenticating if host is not configured
([#1033](#1033)).
* Improve non-JSON error handling
([#1031](#1031)).


### Internal Changes

* Add TestAccCreateOboTokenOnAws to flaky test list
([#1029](#1029)).
* Add workflows manage integration tests checks
([#1032](#1032)).
* Fix TestMwsAccWorkspaces cleanup
([#1028](#1028)).
* Improve integration test comment
([#1035](#1035)).
* Temporary ignore Metastore test failures
([#1027](#1027)).
* Update test to support new accounts
([#1026](#1026)).
* Use statuses instead of checks
([#1036](#1036)).


### API Changes:

* Added `RegenerateDashboard` method for
[w.QualityMonitors](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#QualityMonitorsAPI)
workspace-level service.
* Added
[catalog.RegenerateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardRequest)
and
[catalog.RegenerateDashboardResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardResponse).
* Added
[jobs.QueueDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetails),
[jobs.QueueDetailsCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetailsCodeCode),
[jobs.RunLifecycleStateV2State](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunLifecycleStateV2State),
[jobs.RunStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunStatus),
[jobs.TerminationCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationCodeCode),
[jobs.TerminationDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationDetails)
and
[jobs.TerminationTypeType](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationTypeType).
* Added `Status` field for
[jobs.BaseRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun).
* Added `Status` field for
[jobs.RepairHistoryItem](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RepairHistoryItem).
* Added `Status` field for
[jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).
* Added `Status` field for
[jobs.RunTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunTask).
* Added `MaxProvisionedThroughput` and `MinProvisionedThroughput` fields
for
[serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput).
* Added `ColumnsToSync` field for
[vectorsearch.DeltaSyncVectorIndexSpecRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch#DeltaSyncVectorIndexSpecRequest).
* Changed `WorkloadSize` field for
[serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput)
to no longer be required.

OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants