[Internal] Improve integration test comment

databricks · Sep 2, 2024 · 0d1280b · 0d1280b
1 parent 6ab81ee
commit 0d1280b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 17 deletions.
diff --git a/.github/workflows/check-mark.yml b/.github/workflows/check-mark.yml
@@ -37,8 +37,6 @@ jobs:
             -f 'status=in_progress' \
             -f output[title]="Integration Tests Check" \
             -f output[summary]="Running." \
-            -f output[text]="Tests running:
-                Details https://github.com/databricks-eng/eng-dev-ecosystem/actions/runs/${{inputs.test_run_id}}" \
             /repos/${{github.repository}}/check-runs/${{ inputs.check_run_id }}
 
   mark-as-done:
@@ -53,11 +51,9 @@ jobs:
             --input - <<- EOF
             {
               "conclusion": "success",
-              "details_url": "https://github.com/databricks-eng/eng-dev-ecosystem/actions/runs/${{inputs.test_run_id}}",
               "output": {
                 "title": "Integration Tests Succeed 🚀",
-                "summary": "**Summary**: The tests succeded.",
-                "text": "Details https://github.com/databricks-eng/eng-dev-ecosystem/actions/runs/${{inputs.test_run_id}}"
+                "summary": "**Summary**: The tests succeded."
                }
             }
           EOF
@@ -74,11 +70,9 @@ jobs:
               --input - <<- EOF
               {
                 "conclusion": "failure",
-                "details_url": "https://github.com/${{ github.repository }}/actions/runs/${{inputs.test_run_id}}",
                 "output": {
                   "title": "Integration Tests Failed",
-                  "summary": "**Summary**: The tests failed.",
-                  "text": "Details https://github.com/${{ github.repository }}/actions/runs/${{inputs.test_run_id}}"
+                  "summary": "**Summary**: The tests failed."
                   }
               }
             EOF
@@ -104,9 +98,6 @@ jobs:
                 "<!-- INTEGRATION_TESTS -->
                 Test status:  ${{ github.event.inputs.status}}
                 
-                Workflow: https://github.com/databricks-eng/eng-dev-ecosystem/actions/workflows/sdk-go-isolated-pr.yml 
-                Check Run ID: ${{ inputs.check_run_id }}
-                
                 This check will be approved automatically on success.
                 
                 Check URL: ${{ github.server_url }}/${{ github.repository }}/runs/${{ inputs.check_run_id }}

diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
@@ -24,7 +24,6 @@ jobs:
             -f status='queued' \
             -f output[title]="Integration Tests Check" \
             -f output[summary]="This check is being created." \
-            -f output[text]="This check is being created. Refresh for details." \
             --jq '.id' \
             /repos/${{ github.repository }}/check-runs)
               
@@ -35,8 +34,7 @@ jobs:
             -f name='Integration Tests Check' \
             -f output[title]="Integration Tests Check" \
             -f output[summary]="Waiting for test to run." \
-            -f output[text]="Run the following workflow using the provided check_run_id: 
-                Workflow https://github.com/databricks-eng/eng-dev-ecosystem/actions/workflows/sdk-go-isolated-pr.yml 
+            -f output[text]="Run the corresponding workflow using the provided check_run_id: 
                 Check Run ID: $check_run_id " \
             /repos/${{ github.repository }}/check-runs/$check_run_id
            
@@ -56,9 +54,11 @@ jobs:
           # Add new comment
           gh pr comment ${{ github.event.pull_request.number }} --body \
           "<!-- INTEGRATION_TESTS -->
-          A new approval check has been created. Start integration tests by using the following link.
-          
-          https://github.com/databricks-eng/eng-dev-ecosystem/actions/workflows/sdk-go-isolated-pr.yml/dispatch?pull_request_number=${{github.event.pull_request.number}}&check_run_id=${{ env.CHECK_RUN_ID }}
+          Run integration tests using the corresponding workflow:
+                    
+          Inputs:
+          pull_request_number=${{github.event.pull_request.number}}
+          check_run_id=${{ env.CHECK_RUN_ID }}
           
           This check will be approved automatically on success.