Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Use statuses instead of checks #1036

Merged
merged 3 commits into from
Sep 3, 2024
Merged

[Internal] Use statuses instead of checks #1036

merged 3 commits into from
Sep 3, 2024

Conversation

hectorcast-db
Copy link
Contributor

@hectorcast-db hectorcast-db commented Sep 3, 2024

Changes

Use statuses instead of checks

Tests

This PR

Screenshot 2024-09-03 at 09 19 44

@hectorcast-db hectorcast-db force-pushed the test-enforce branch 17 times, most recently from d3d0b3d to b9d7273 Compare September 3, 2024 07:08
@databricks databricks deleted a comment from github-actions bot Sep 3, 2024
@databricks databricks deleted a comment from github-actions bot Sep 3, 2024
@hectorcast-db hectorcast-db force-pushed the test-enforce branch 2 times, most recently from 6a371ff to f009bd6 Compare September 3, 2024 07:15
@hectorcast-db hectorcast-db changed the title Random change [Internal] Use statuses instead of tests Sep 3, 2024
@hectorcast-db hectorcast-db changed the title [Internal] Use statuses instead of tests [Internal] Use statuses instead of checks Sep 3, 2024
@hectorcast-db hectorcast-db force-pushed the test-enforce branch 2 times, most recently from bab25a7 to 417f050 Compare September 3, 2024 07:24
@github-actions github-actions bot deleted a comment from eng-dev-ecosystem-bot Sep 3, 2024
@databricks databricks deleted a comment from github-actions bot Sep 3, 2024
@hectorcast-db hectorcast-db added this pull request to the merge queue Sep 3, 2024
@hectorcast-db hectorcast-db removed this pull request from the merge queue due to a manual request Sep 3, 2024
@hectorcast-db hectorcast-db added this pull request to the merge queue Sep 3, 2024
@hectorcast-db hectorcast-db removed this pull request from the merge queue due to a manual request Sep 3, 2024
@github-actions github-actions bot deleted a comment from eng-dev-ecosystem-bot Sep 3, 2024
@databricks databricks deleted a comment from github-actions bot Sep 3, 2024
@hectorcast-db hectorcast-db added this pull request to the merge queue Sep 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 3, 2024
## Changes
Use statuses instead of checks

## Tests
<!-- 
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

This PR

![Screenshot 2024-09-03 at 09 19
44](https://github.com/user-attachments/assets/bfc6a04a-6d84-4212-b0b8-9bd884b4aaf8)
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2024
@github-actions github-actions bot deleted a comment from eng-dev-ecosystem-bot Sep 3, 2024
@databricks databricks deleted a comment from github-actions bot Sep 3, 2024
@hectorcast-db hectorcast-db added this pull request to the merge queue Sep 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2024
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test status: success
Commit SHA: 4d734f0

@hectorcast-db hectorcast-db added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 34f37f9 Sep 3, 2024
11 checks passed
@hectorcast-db hectorcast-db deleted the test-enforce branch September 3, 2024 12:45
mgyucht added a commit that referenced this pull request Sep 4, 2024
### Bug Fixes

 * Fail fast when authenticating if host is not configured ([#1033](#1033)).
 * Improve non-JSON error handling ([#1031](#1031)).

### Internal Changes

 * Add TestAccCreateOboTokenOnAws to flaky test list ([#1029](#1029)).
 * Add workflows manage integration tests checks ([#1032](#1032)).
 * Fix TestMwsAccWorkspaces cleanup ([#1028](#1028)).
 * Improve integration test comment ([#1035](#1035)).
 * Temporary ignore Metastore test failures ([#1027](#1027)).
 * Update test to support new accounts ([#1026](#1026)).
 * Use statuses instead of checks ([#1036](#1036)).

### API Changes:

 * Added `RegenerateDashboard` method for [w.QualityMonitors](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#QualityMonitorsAPI) workspace-level service.
 * Added [catalog.RegenerateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardRequest) and [catalog.RegenerateDashboardResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardResponse).
 * Added [jobs.QueueDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetails), [jobs.QueueDetailsCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetailsCodeCode), [jobs.RunLifecycleStateV2State](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunLifecycleStateV2State), [jobs.RunStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunStatus), [jobs.TerminationCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationCodeCode), [jobs.TerminationDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationDetails) and [jobs.TerminationTypeType](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationTypeType).
 * Added `Status` field for [jobs.BaseRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun).
 * Added `Status` field for [jobs.RepairHistoryItem](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RepairHistoryItem).
 * Added `Status` field for [jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).
 * Added `Status` field for [jobs.RunTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunTask).
 * Added `MaxProvisionedThroughput` and `MinProvisionedThroughput` fields for [serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput).
 * Added `ColumnsToSync` field for [vectorsearch.DeltaSyncVectorIndexSpecRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch#DeltaSyncVectorIndexSpecRequest).
 * Changed `WorkloadSize` field for [serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput) to no longer be required.

OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
### Bug Fixes

* Fail fast when authenticating if host is not configured
([#1033](#1033)).
* Improve non-JSON error handling
([#1031](#1031)).


### Internal Changes

* Add TestAccCreateOboTokenOnAws to flaky test list
([#1029](#1029)).
* Add workflows manage integration tests checks
([#1032](#1032)).
* Fix TestMwsAccWorkspaces cleanup
([#1028](#1028)).
* Improve integration test comment
([#1035](#1035)).
* Temporary ignore Metastore test failures
([#1027](#1027)).
* Update test to support new accounts
([#1026](#1026)).
* Use statuses instead of checks
([#1036](#1036)).


### API Changes:

* Added `RegenerateDashboard` method for
[w.QualityMonitors](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#QualityMonitorsAPI)
workspace-level service.
* Added
[catalog.RegenerateDashboardRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardRequest)
and
[catalog.RegenerateDashboardResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#RegenerateDashboardResponse).
* Added
[jobs.QueueDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetails),
[jobs.QueueDetailsCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#QueueDetailsCodeCode),
[jobs.RunLifecycleStateV2State](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunLifecycleStateV2State),
[jobs.RunStatus](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunStatus),
[jobs.TerminationCodeCode](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationCodeCode),
[jobs.TerminationDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationDetails)
and
[jobs.TerminationTypeType](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#TerminationTypeType).
* Added `Status` field for
[jobs.BaseRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun).
* Added `Status` field for
[jobs.RepairHistoryItem](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RepairHistoryItem).
* Added `Status` field for
[jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).
* Added `Status` field for
[jobs.RunTask](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunTask).
* Added `MaxProvisionedThroughput` and `MinProvisionedThroughput` fields
for
[serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput).
* Added `ColumnsToSync` field for
[vectorsearch.DeltaSyncVectorIndexSpecRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch#DeltaSyncVectorIndexSpecRequest).
* Changed `WorkloadSize` field for
[serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput)
to no longer be required.

OpenAPI SHA: d05898328669a3f8ab0c2ecee37db2673d3ea3f7, Date: 2024-09-04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants