-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: deserialization of former required field #1885
Draft
shumkov
wants to merge
211
commits into
master
Choose a base branch
from
fix/deserialization-of-former-required-field
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ivan Shumkov <[email protected]>
…-check (#1647) Co-authored-by: Ivan Shumkov <[email protected]>
…ommitted (#1663) Co-authored-by: Quantum Explorer <[email protected]>
Co-authored-by: QuantumExplorer <[email protected]>
Co-authored-by: QuantumExplorer <[email protected]>
Co-authored-by: Odysseas Gabrielides <[email protected]> Co-authored-by: Ivan Shumkov <[email protected]>
Co-authored-by: Odysseas Gabrielides <[email protected]> Co-authored-by: Ivan Shumkov <[email protected]>
Co-authored-by: Paul DeLucia <[email protected]>
Co-authored-by: lklimek <[email protected]>
We decided to postpone this till after release, for now required fields can not change to optional. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Data Contract Update functionality allows developers to make previously required fields optional. This is required for application model evolution in case a developer wants to deprecate an old field so clients don't need to provide a value for this field. For example, a developer needs to change the field type. He/she needs to create a new field with a new type and mark the old field as optional (not required).
Currently, document serialization logic doesn't use the marker of presence for fields that are marked as required. Since the required flag can be removed with the data contract update, such serialized data becomes invalid.
What was done?
How Has This Been Tested?
Breaking Changes
Previously serialized documents with required fields won't be valid.
Checklist:
For repository code-owners and collaborators only