Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(dapi): cache getBestBlockHash endpoint #1867

Merged
merged 2 commits into from
May 30, 2024
Merged

perf(dapi): cache getBestBlockHash endpoint #1867

merged 2 commits into from
May 30, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented May 29, 2024 •
edited
Loading

Issue being fixed or feature implemented

Core RPC work queue has limited size. We should do as less RPC calls as possible.

What was done?

  • Cached getBestBlockHash response for one Core block

How Has This Been Tested?

Updated tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov marked this pull request as ready for review May 30, 2024 08:37
@shumkov shumkov changed the title pref(dapi): cache getBestBlockHash endpoint perf(dapi): cache getBestBlockHash endpoint May 30, 2024
@shumkov shumkov merged commit bc5f55d into v1.0-dev May 30, 2024
20 checks passed
@shumkov shumkov deleted the perf/dapi/cache-best-block-hash branch May 30, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshenmic pshenmic pshenmic approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @pshenmic