Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dpp): make data contract factory and json schema validator public #1871

Merged
merged 2 commits into from
Jun 4, 2024
Merged

chore(dpp): make data contract factory and json schema validator public #1871

merged 2 commits into from
Jun 4, 2024

Conversation

pauldelucia
Copy link
Member

Issue being fixed or feature implemented

DataContractFactory and JsonSchemaValidator were not public and I need them in data-contract-creator.

What was done?

Made them public.

How Has This Been Tested?

dashpay.io

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title feat: make data contract factory and json schema validator public chore: make data contract factory and json schema validator public Jun 4, 2024
@shumkov shumkov changed the title chore: make data contract factory and json schema validator public chore(dpp): make data contract factory and json schema validator public Jun 4, 2024
shumkov
shumkov approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pauldelucia pauldelucia merged commit c03a5f8 into v1.0-dev Jun 4, 2024
63 checks passed
@pauldelucia pauldelucia deleted the feat/make-things-public-for-dashpay-io branch June 4, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldelucia @shumkov