refactor(rpc): Mechanical/Manual RPC backports #4734

Munkybooty · 2022-03-19T20:18:43Z

No description provided.

Munkybooty · 2022-03-29T16:25:35Z

I need to clean up 27a055d, the commit message should say why, but It does need to be fixed, as per Pasta's request i will batch the changes for easier review

github-actions · 2022-04-01T05:22:05Z

This pull request has conflicts, please rebase.

github-actions · 2022-04-07T10:19:09Z

This pull request has conflicts, please rebase.

Munkybooty · 2022-04-08T21:29:46Z

I honestly am unsure of what all is needed to fix the breakages
@UdjinM6 any thoughts?

UdjinM6

Well.. some parts are missing and some changes are excessive :) You also need to revert few things and adjust dash-specific rpcs to make them compatible with Check(). Pls see https://github.com/UdjinM6/dash/commits/pr4734. (these changes are huge so pretty sure I messed up somewhere too, pls double check/test)

Munkybooty · 2022-04-19T05:50:59Z

So I implemented the changes and feature_llmq_rotations has just decided to die

PastaPastaPasta · 2022-04-19T13:26:30Z

Well, it seems like you messed up the quorum rpc command. See

2022-04-16T20:50:22.877000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/builds/dashpay/dash/build-ci/dashcore-linux32/test/functional/test_framework/test_framework.py", line 234, in main
    self.run_test()
  File "/builds/dashpay/dash/build-ci/dashcore-linux32/test/functional/feature_llmq_rotation.py", line 67, in run_test
    (quorum_info_0_0, quorum_info_0_1) = self.mine_cycle_quorum(llmq_type_name=llmq_type_name, llmq_type=llmq_type)
  File "/builds/dashpay/dash/build-ci/dashcore-linux32/test/functional/test_framework/test_framework.py", line 1456, in mine_cycle_quorum
    quorum_rotation_info = self.nodes[0].quorum("rotationinfo", best_block_hash, 0, False)
  File "/builds/dashpay/dash/build-ci/dashcore-linux32/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/builds/dashpay/dash/build-ci/dashcore-linux32/test/functional/test_framework/authproxy.py", line 144, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: quorum "command"
Set of commands for quorums/LLMQs.
To get help on individual commands, use "help quorum command".

Available commands:
  list              - List of on-chain quorums
  info              - Return information about a quorum
  dkgsimerror       - Simulates DKG errors and malicious behavior
  dkgstatus         - Return the status of the current DKG process
  memberof          - Checks which quorums the given masternode is a member of
  sign              - Threshold-sign a message
  verify            - Test if a quorum signature is valid for a request id and a message hash
  hasrecsig         - Test if a valid recovered signature is present
  getrecsig         - Get a recovered signature
  isconflicting     - Test if a conflict exists
  selectquorum      - Return the quorum that would/should sign a request
  getdata           - Request quorum data from other masternodes in the quorum
  rotationinfo      - Request quorum rotation information

Arguments:
1. command    (string, required) The command to execute
 (-1)
2022-04-16T20:50:22.929000Z TestFramework (INFO): Stopping nodes
2022-04-16T20:50:23.596000Z TestFramework (WARNING): Not cleaning up dir /builds/dashpay/dash/build-ci/dashcore-linux32/testdatadirs/test_runner_âˆ‹_ðŸ�ƒ_20220416_214406/feature_llmq_rotation_131
2022-04-16T20:50:23.596000Z TestFramework (ERROR): Test failed. Test logging available at /builds/dashpay/dash/build-ci/dashcore-linux32/testdatadirs/test_runner_âˆ‹_ðŸ�ƒ_20220416_214406/feature_llmq_rotation_131/test_framework.log

github-actions · 2022-04-20T13:36:22Z

This pull request has conflicts, please rebase.

Munkybooty · 2022-04-20T20:56:38Z

I wanna say I fixed it but now p2p_instantsend.py is broken, it's progress though! One thing fixed and another thing broke

UdjinM6 · 2022-04-21T02:11:33Z

I wanna say I fixed it but now p2p_instantsend.py is broken, it's progress though! One thing fixed and another thing broke

this should be fixed by #4790, ~~pls rebase~~ hold on, there is more...

UdjinM6 · 2022-04-25T19:12:13Z

pls see ff954e0add

github-actions · 2022-05-02T19:08:38Z

This pull request has conflicts, please rebase.

TODO: convert `RPCResults{}`

This reverts commit c014b7d.

to fix test crashes

UdjinM6

LGTM, utACK

(sooo many conflicting PRs...)

Munkybooty · 2022-05-12T20:24:01Z

Totally forgot this thing has sat as a draft this whole time

PastaPastaPasta

utACK for squash merge

time to make everything else need rebase :D

Munkybooty · 2022-05-12T20:29:28Z

Panic Mode

* rpc: switch to using RPCHelpMan.Check() * rpc: Auto-format RPCResult * rpc: Auto-format RPCResult (rpcdump.cpp) * rpc: Auto-format RPCResult (rpcwallet.cpp) * Fix Description String method and typo * Fix code breaking semicolons * Attempt to fix misc build errors * Fixes for get wallet info * fixes and missing parts of 16240, 17809, 19386 TODO: convert `RPCResults{}` * Revert "rpc: restore legacy RPCResult support" This reverts commit c014b7d. * revert e401d6e to fix test crashes * adjust dash subcommands to be compatible * trivial fixes rpc: Auto-format RPCResult * fix `quorum rotationinfo` * various fixes Co-authored-by: Karl-Johan Alm <karljohan-alm@garage.co.jp> Co-authored-by: MarcoFalke <falke.marco@gmail.com> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Munkybooty force-pushed the iss45 branch from 3f27cc9 to e4ab57d Compare March 24, 2022 18:25

Munkybooty force-pushed the iss45 branch from 27a055d to 0fc9329 Compare March 31, 2022 17:16

github-actions bot added the needs rebase label Apr 1, 2022

Munkybooty force-pushed the iss45 branch 2 times, most recently from 98f3349 to 201af0a Compare April 6, 2022 06:13

github-actions bot removed the needs rebase label Apr 6, 2022

Munkybooty force-pushed the iss45 branch from 201af0a to 1ae76c1 Compare April 7, 2022 07:45

github-actions bot added the needs rebase label Apr 7, 2022

Munkybooty force-pushed the iss45 branch from 1ae76c1 to ad29557 Compare April 7, 2022 16:09

github-actions bot removed the needs rebase label Apr 7, 2022

UdjinM6 requested changes Apr 14, 2022

View reviewed changes

Munkybooty force-pushed the iss45 branch from 035b287 to b714680 Compare April 16, 2022 20:32

github-actions bot added the needs rebase label Apr 20, 2022

Munkybooty force-pushed the iss45 branch from b714680 to 6f646e1 Compare April 20, 2022 19:30

github-actions bot removed the needs rebase label Apr 20, 2022

Munkybooty force-pushed the iss45 branch from 6f646e1 to 6437b3b Compare April 21, 2022 15:28

UdjinM6 mentioned this pull request Apr 26, 2022

rpc: fix and simplify quorum rotationinfo #4808

Merged

Munkybooty force-pushed the iss45 branch from 8a9a884 to 6437b3b Compare April 26, 2022 10:57

UdjinM6 mentioned this pull request Apr 26, 2022

merge bitcoin#17319...19601: muhash implementation #4704

Merged

github-actions bot added the needs rebase label Apr 26, 2022

github-actions bot added the needs rebase label May 2, 2022

kallewoof and others added 14 commits May 4, 2022 02:54

rpc: switch to using RPCHelpMan.Check()

12173ca

rpc: Auto-format RPCResult

c66e38b

rpc: Auto-format RPCResult (rpcdump.cpp)

e446ae5

rpc: Auto-format RPCResult (rpcwallet.cpp)

089601d

Fix Description String method and typo

b557dd9

Fix code breaking semicolons

74d6c3e

Attempt to fix misc build errors

766ece0

Fixes for get wallet info

57dcfe7

fixes and missing parts of 16240, 17809, 19386

7311394

TODO: convert `RPCResults{}`

Revert "rpc: restore legacy RPCResult support"

cdfe630

This reverts commit c014b7d.

revert e401d6e

216b4c1

to fix test crashes

adjust dash subcommands to be compatible

7105d42

trivial fixes rpc: Auto-format RPCResult

bbfebb9

fix quorum rotationinfo

6239256

Munkybooty force-pushed the iss45 branch from 5b4b839 to 6239256 Compare May 4, 2022 06:56

github-actions bot removed the needs rebase label May 4, 2022

various fixes

aed28ed

UdjinM6 added this to the 18.1 milestone May 12, 2022

UdjinM6 approved these changes May 12, 2022

View reviewed changes

Munkybooty marked this pull request as ready for review May 12, 2022 20:23

PastaPastaPasta changed the title ~~Mechanical/Manual RPC backports~~ refactor(rpc): Mechanical/Manual RPC backports May 12, 2022

PastaPastaPasta approved these changes May 12, 2022

View reviewed changes

PastaPastaPasta merged commit e95655c into dashpay:develop May 12, 2022

UdjinM6 mentioned this pull request May 12, 2022

feat(rpc/wallet): allow skipping/forcing blockchain rescan on upgradetohd #4822

Merged

refactor(rpc): Mechanical/Manual RPC backports #4734

refactor(rpc): Mechanical/Manual RPC backports #4734

Uh oh!

Conversation

Munkybooty commented Mar 19, 2022

Uh oh!

Munkybooty commented Mar 29, 2022

Uh oh!

github-actions bot commented Apr 1, 2022

Uh oh!

github-actions bot commented Apr 7, 2022

Uh oh!

Munkybooty commented Apr 8, 2022

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Munkybooty commented Apr 19, 2022

Uh oh!

PastaPastaPasta commented Apr 19, 2022

Uh oh!

github-actions bot commented Apr 20, 2022

Uh oh!

Munkybooty commented Apr 20, 2022

Uh oh!

UdjinM6 commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UdjinM6 commented Apr 25, 2022

Uh oh!

github-actions bot commented May 2, 2022

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Munkybooty commented May 12, 2022

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

Munkybooty commented May 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

UdjinM6 commented Apr 21, 2022 •

edited

Loading