rpc: fix and simplify quorum rotationinfo
#4808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues with current implementation: params list is not mentioning `baseBlockHashes`, `baseBlockHashesNb` looks excessive, no default values, handling of baseBlockHash-es is off by 1 (`3 + i` should be `4 + i`). before: ``` > help quorum rotationinfo quorum rotationinfo "blockRequestHash" baseBlockHashesNb extraShare Get quorum rotation information Arguments: 1. blockRequestHash (string, required) The blockHash of the request. 2. baseBlockHashesNb (numeric, required) Number of baseBlockHashes 3. extraShare (boolean, required) Extra share ``` after: ``` > help quorum rotationinfo quorum rotationinfo "blockRequestHash" ( extraShare "baseBlockHash..." ) Get quorum rotation information Arguments: 1. blockRequestHash (string, required) The blockHash of the request. 2. extraShare (boolean, optional, default=false) Extra share 3. baseBlockHash... (string, optional, default=) baseBlockHashes ```
UdjinM6
added
RPC
PastaPastaPasta
approved these changes
Apr 26, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 26, 2022
Issues with current implementation: params list is not mentioning `baseBlockHashes`, `baseBlockHashesNb` looks excessive, no default values, handling of baseBlockHash-es is off by 1 (`3 + i` should be `4 + i`). before: ``` > help quorum rotationinfo quorum rotationinfo "blockRequestHash" baseBlockHashesNb extraShare Get quorum rotation information Arguments: 1. blockRequestHash (string, required) The blockHash of the request. 2. baseBlockHashesNb (numeric, required) Number of baseBlockHashes 3. extraShare (boolean, required) Extra share ``` after: ``` > help quorum rotationinfo quorum rotationinfo "blockRequestHash" ( extraShare "baseBlockHash..." ) Get quorum rotation information Arguments: 1. blockRequestHash (string, required) The blockHash of the request. 2. extraShare (boolean, optional, default=false) Extra share 3. baseBlockHash... (string, optional, default=) baseBlockHashes ```
thephez
reviewed
Apr 28, 2022
| { | ||
| {"blockRequestHash", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The blockHash of the request"}, | ||
| {"extraShare", RPCArg::Type::BOOL, /* default */ "false", "Extra share"}, | ||
| {"baseBlockHash...", RPCArg::Type::STR_HEX, /* default*/ "", "baseBlockHashes"}, |
Collaborator
There was a problem hiding this comment.
Why is this argument name truncated?
Author
There was a problem hiding this comment.
... just indicates that there are many of them. We could probably turn it into a json array instead if that would make it clearer.
Collaborator
There was a problem hiding this comment.
So it's just multiple strings separated by spaces? Is there a limit to how many can be put there?
Author
There was a problem hiding this comment.
yes, it's multiple hashes. There is no limit atm (there was none in the code I refactored so I kept it). I'm not sure if we have to put one in place though.. Thoughts @ogabrielides @PastaPastaPasta ?
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Dec 1, 2023
Issues with current implementation: params list is not mentioning `baseBlockHashes`, `baseBlockHashesNb` looks excessive, no default values, handling of baseBlockHash-es is off by 1 (`3 + i` should be `4 + i`). before: ``` > help quorum rotationinfo quorum rotationinfo "blockRequestHash" baseBlockHashesNb extraShare Get quorum rotation information Arguments: 1. blockRequestHash (string, required) The blockHash of the request. 2. baseBlockHashesNb (numeric, required) Number of baseBlockHashes 3. extraShare (boolean, required) Extra share ``` after: ``` > help quorum rotationinfo quorum rotationinfo "blockRequestHash" ( extraShare "baseBlockHash..." ) Get quorum rotation information Arguments: 1. blockRequestHash (string, required) The blockHash of the request. 2. extraShare (boolean, optional, default=false) Extra share 3. baseBlockHash... (string, optional, default=) baseBlockHashes ```
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
Issues with current implementation: params list is not mentioning `baseBlockHashes`, `baseBlockHashesNb` looks excessive, no default values, handling of baseBlockHash-es is off by 1 (`3 + i` should be `4 + i`). before: ``` > help quorum rotationinfo quorum rotationinfo "blockRequestHash" baseBlockHashesNb extraShare Get quorum rotation information Arguments: 1. blockRequestHash (string, required) The blockHash of the request. 2. baseBlockHashesNb (numeric, required) Number of baseBlockHashes 3. extraShare (boolean, required) Extra share ``` after: ``` > help quorum rotationinfo quorum rotationinfo "blockRequestHash" ( extraShare "baseBlockHash..." ) Get quorum rotation information Arguments: 1. blockRequestHash (string, required) The blockHash of the request. 2. extraShare (boolean, optional, default=false) Extra share 3. baseBlockHash... (string, optional, default=) baseBlockHashes ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues with current implementation: params list is not mentioning
baseBlockHashes,baseBlockHashesNblooks excessive, no default values, handling of baseBlockHash-es is off by 1 (3 + ishould be4 + i).before:
after:
Noticed this while reviewing #4734 (note to @Munkybooty: this patch is doing even more than the one I proposed there initially, you'll have to adjust 4734 accordingly on rebase)