Skip to content

feat(rpc/wallet): allow skipping/forcing blockchain rescan on upgradetohd #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UdjinM6 merged 3 commits into from
May 16, 2022
Merged

feat(rpc/wallet): allow skipping/forcing blockchain rescan on upgradetohd #4822

UdjinM6 merged 3 commits into from
May 16, 2022

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Apr 30, 2022

Use cases:

  1. "I-know-what-I'm-doing mode": I want a wallet with a specific mnemonic and I know it was never used before (or I don't care about old txes for some reason), I don't need any rescans
  2. "paranoid mode": make sure the new mnemonic that was just generated (when there was no mnemonic provided via params) was never used before

@UdjinM6 UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Apr 30, 2022
@UdjinM6 UdjinM6 added this to the 18.1 milestone Apr 30, 2022
@UdjinM6 UdjinM6 force-pushed the skip_hdupg_rescan branch from acef111 to 7d72cc0 Compare April 30, 2022 20:23
PastaPastaPasta
PastaPastaPasta reviewed May 2, 2022
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add release notes for this

PastaPastaPasta
PastaPastaPasta previously approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@github-actions
Copy link

github-actions bot commented May 12, 2022

This pull request has conflicts, please rebase.

@UdjinM6 UdjinM6 force-pushed the skip_hdupg_rescan branch from 8e6b086 to 58c0308 Compare May 12, 2022 20:43
@UdjinM6
Copy link
Author

UdjinM6 commented May 12, 2022

rebased after #4734

@PastaPastaPasta PastaPastaPasta changed the title wallet: allow skipping/forcing blockchain rescan on upgradetohd feat(rpc/wallet): allow skipping/forcing blockchain rescan on upgradetohd May 13, 2022
PastaPastaPasta
PastaPastaPasta approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@UdjinM6 UdjinM6 merged commit 56898d2 into dashpay:develop May 16, 2022
@UdjinM6 UdjinM6 deleted the skip_hdupg_rescan branch August 30, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

RPC Some notable changes to RPC params/behaviour/descriptions

Projects

None yet

Milestone

18.1

Development

Successfully merging this pull request may close these issues.

2 participants

@UdjinM6 @PastaPastaPasta