Console warnings in pages with embedded DartPads #791

kwalrath · 2017-11-10T21:45:12Z

dart-lang/site-www#422 reports 3 Chrome console warnings in at least 4 pages, all of which have embedded DartPads. (No warnings appear in other, non-DartPad-containing pages that I've spot checked, such as www.dartlang.org and www.dartlang.org/dart-2.0.)

I also see console warnings in those pages (but 2, not 3). For example, here are the warnings for https://www.dartlang.org/guides/get-started:

[Deprecation] Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M65, around March 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.
[Deprecation] /deep/ combinator is no longer supported in CSS dynamic profile.It is now effectively no-op, acting as if it were a descendant combinator. /deep/ combinator will be removed, and will be invalid at M65. You should remove it. See https://www.chromestatus.com/features/4964279606312960 for more details.

I'm using Chrome Canary: Version 64.0.3261.0 (Official Build) canary (64-bit).

Georgehe4 · 2017-11-10T22:55:21Z

The polymer components are out of date and will need to be updated in the near future.

kwalrath · 2018-03-05T18:37:40Z

Thanks, @Georgehe4!

@devoncarew please let us know when the changes go live, so I can close dart-lang/site-www#422.

Georgehe4 · 2018-03-05T18:40:40Z

The changes should be live now. There will still be warnings but there will be no impact on anything the users see in their browser. Hopefully polymer will update their build process to remove the warnings soon.

…

On Mon, Mar 5, 2018 at 1:38 PM, Kathy Walrath ***@***.***> wrote: Thanks, @Georgehe4 <https://github.com/georgehe4>! @devoncarew <https://github.com/devoncarew> please let us know when the changes go live, so I can close this issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#791 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADARlAmk-ShXV9nmgu2au8E5tbzf-o6gks5tbYX1gaJpZM4QaJvt> .

kwalrath · 2018-03-05T18:53:43Z

Ah, OK, I'll leave dart-lang/site-www#422 open then. I currently see 4 browser warnings in https://www.dartlang.org/guides/get-started:

[Deprecation] Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M67, around May 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.
imports.html:11890 This file is deprecated. Please use iron-flex-layout/iron-flex-layout-classes.html, and one of the specific dom-modules instead
imports.html:12193 This file is deprecated. Please use iron-flex-layout/iron-flex-layout-classes.html, and one of the specific dom-modules instead
[Deprecation] /deep/ combinator is no longer supported in CSS dynamic profile.It is now effectively no-op, acting as if it were a descendant combinator. /deep/ combinator will be removed, and will be invalid at M65. You should remove it. See https://www.chromestatus.com/features/4964279606312960 for more details.

chalin · 2018-04-20T19:08:43Z

The deprecation notice deadline is approaching:

planned to be removed in M67, around May 2018

Any update on this. Btw, this impacts both https://www.dartlang.org and https://webdev.dartlang.org.

Georgehe4 · 2018-05-08T13:09:54Z

Hey @chalin, the deprecation notices will be present until Polymer/polymer#4679 is addressed. The site will still function after the /deep/ combinator is removed.

jcollins-g · 2018-06-15T23:22:33Z

While it doesn't seem to break Dartpad, there are more errors now:

(seen today on https://www.dartlang.org/guides/language/language-tour)

As a first guess, this may be a result of some the changes I made in #826. Will investigate first thing Monday.

Failed to load resource: the server responded with a status of 400 ()
async_patch.dart:726 Uncaught Error: DetailedApiRequestError(status: 400, message: main.dart:
Error: No 'main' method found.

Error: Compilation failed.
)
    at Object.a (js_helper.dart:1759)
    at yj.dart.yj.$1 (clients.dart:881)
    at ww.fH (zone.dart:1381)
    at fP.md (future_impl.dart:129)
    at vA.$0 (future_impl.dart:633)
    at Object.ca (future_impl.dart:662)
    at F.aE (future_impl.dart:467)
    at Object.dh (stream_pipe.dart:63)
    at tE.dart.tE.$1 (stream.dart:1149)
    at ww.fI (zone.dart:1316)
dart-services.appspot.com/api/dartservices/v1/compile?alt=json:1 Failed to load resource: the server responded with a status of 400 ()
async_patch.dart:726 Uncaught Error: DetailedApiRequestError(status: 400, message: main.dart:
Error: No 'main' method found.

Error: Compilation failed.
)
    at Object.a (js_helper.dart:1759)
    at yj.dart.yj.$1 (clients.dart:881)
    at ww.fH (zone.dart:1381)
    at fP.md (future_impl.dart:129)
    at vA.$0 (future_impl.dart:633)
    at Object.ca (future_impl.dart:662)
    at F.aE (future_impl.dart:467)
    at Object.dh (stream_pipe.dart:63)
    at tE.dart.tE.$1 (stream.dart:1149)
    at ww.fI (zone.dart:1316)
dart-services.appspot.com/api/dartservices/v1/compile?alt=json:1 Failed to load resource: the server responded with a status of 400 ()
async_patch.dart:726 Uncaught Error: DetailedApiRequestError(status: 400, message: main.dart:
Error: No 'main' method found.

Error: Compilation failed.
)
    at Object.a (js_helper.dart:1759)
    at yj.dart.yj.$1 (clients.dart:881)
    at ww.fH (zone.dart:1381)
    at fP.md (future_impl.dart:129)
    at vA.$0 (future_impl.dart:633)
    at Object.ca (future_impl.dart:662)
    at F.aE (future_impl.dart:467)
    at Object.dh (stream_pipe.dart:63)
    at tE.dart.tE.$1 (stream.dart:1149)
    at ww.fI (zone.dart:1316)
dart-services.appspot.com/api/dartservices/v1/compile?alt=json:1 Failed to load resource: the server responded with a status of 400 ()
async_patch.dart:726 Uncaught Error: DetailedApiRequestError(status: 400, message: main.dart:
Error: No 'main' method found.

Error: Compilation failed.
)
    at Object.a (js_helper.dart:1759)
    at yj.dart.yj.$1 (clients.dart:881)
    at ww.fH (zone.dart:1381)
    at fP.md (future_impl.dart:129)
    at vA.$0 (future_impl.dart:633)
    at Object.ca (future_impl.dart:662)
    at F.aE (future_impl.dart:467)
    at Object.dh (stream_pipe.dart:63)
    at tE.dart.tE.$1 (stream.dart:1149)
    at ww.fI (zone.dart:1316)
dart-services.appspot.com/api/dartservices/v1/compile?alt=json:1 Failed to load resource: the server responded with a status of 400 ()
async_patch.dart:726 Uncaught Error: DetailedApiRequestError(status: 400, message: main.dart:
Error: No 'main' method found.

Error: Compilation failed.
)
    at Object.a (js_helper.dart:1759)
    at yj.dart.yj.$1 (clients.dart:881)
    at ww.fH (zone.dart:1381)
    at fP.md (future_impl.dart:129)
    at vA.$0 (future_impl.dart:633)
    at Object.ca (future_impl.dart:662)
    at F.aE (future_impl.dart:467)
    at Object.dh (stream_pipe.dart:63)
    at tE.dart.tE.$1 (stream.dart:1149)
    at ww.fI (zone.dart:1316)

jcollins-g · 2018-06-15T23:26:12Z

These might be connected to these other warnings on that same page:

blob:https://dartpad.dartlang.org/7f6d46a6-1735-469e-8d44-0e93364a27a9:1 Failed to load resource: net::ERR_FILE_NOT_FOUND
blob:https://dartpad.dartlang.org/0ca7ebb3-b95e-4b72-bdc0-064e7dd98fd4:1 Failed to load resource: net::ERR_FILE_NOT_FOUND
blob:https://dartpad.dartlang.org/7b29795c-4c3c-4ccb-ad5b-8cfb968965bb:1 Failed to load resource: net::ERR_FILE_NOT_FOUND
blob:https://dartpad.dartlang.org/c1fb6f93-95a5-4258-bf10-22a57c2ccbf7:1 Failed to load resource: net::ERR_FILE_NOT_FOUND
blob:https://dartpad.dartlang.org/838938ce-e192-44c3-80c5-c17ea57b2eb0:1 Failed to load resource: net::ERR_FILE_NOT_FOUND

jcollins-g · 2018-06-18T20:54:08Z

Compilation failed warnings seem to be the result of some kind of initialization timing race. It's reproducible locally in the embedder_demo.html that loads Hello World, and results in the program not being correctly auto-run by the embedder.

jcollins-g · 2018-06-18T21:30:41Z

The Uncaught Errors on page load are caused by attempting to compile a gist that hasn't loaded yet, here:

dart-pad/lib/embed/embed.dart

Line 102 in 4f3c839

_storePreviousResult();

jcollins-g · 2018-07-13T16:11:23Z

Some of the remaining console warnings seem to be coming from codemirror. I've got a patch that seems to solve it but I want to look into getting it into upstream. The embedded-specific warnings I haven't looked at yet.

RedBrogdon · 2019-04-22T16:13:11Z

The polymer warnings will persist until the new embed UI replaces the current embed UI. I'm not seeing any CodeMirror-related warnings at this point.

chalin · 2019-11-14T20:07:36Z

Is this issue still relevant -- are the original warnings still being issued?

RedBrogdon · 2019-11-14T20:18:41Z

@johnpryan swapped the new embed UI for the old one a while back, so there should no longer be any polymer code loading into anyone's browser. This should be closed at this point.

Co-authored-by: Brett Morgan <[email protected]>

kwalrath changed the title ~~Console warnings in embedded DartPads~~ Console warnings in pages with embedded DartPads Nov 10, 2017

Georgehe4 added the ui punchlist label Nov 10, 2017

Georgehe4 added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Feb 3, 2018

Georgehe4 mentioned this issue Feb 25, 2018

Update polymer to 1.11.2 #797

Merged

kwalrath mentioned this issue Mar 5, 2018

Remove embedded DartPads dart-lang/site-www#422

Closed

jcollins-g mentioned this issue Jun 15, 2018

Embrace optional new/const in the language tour dart-lang/site-www#940

Merged

jcollins-g mentioned this issue Jun 18, 2018

Fix uncaught embedded exceptions on gist loading #829

Merged

jcollins-g added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Oct 19, 2018

RedBrogdon removed the ui punchlist label Apr 22, 2019

RedBrogdon added this to the Backlog milestone Apr 22, 2019

RedBrogdon closed this as completed Nov 14, 2019

johnpryan pushed a commit to johnpryan/dart-pad that referenced this issue Jun 27, 2023

Decouple version bumps from other grinder tasks (dart-lang#791)

e5f2671

Co-authored-by: Brett Morgan <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Console warnings in pages with embedded DartPads #791

Console warnings in pages with embedded DartPads #791

kwalrath commented Nov 10, 2017

Georgehe4 commented Nov 10, 2017

kwalrath commented Mar 5, 2018 •

edited

Loading

Georgehe4 commented Mar 5, 2018 via email

kwalrath commented Mar 5, 2018 •

edited

Loading

chalin commented Apr 20, 2018

Georgehe4 commented May 8, 2018

jcollins-g commented Jun 15, 2018

jcollins-g commented Jun 15, 2018

jcollins-g commented Jun 18, 2018

jcollins-g commented Jun 18, 2018

jcollins-g commented Jul 13, 2018 •

edited

Loading

RedBrogdon commented Apr 22, 2019

chalin commented Nov 14, 2019

RedBrogdon commented Nov 14, 2019

Console warnings in pages with embedded DartPads #791

Console warnings in pages with embedded DartPads #791

Comments

kwalrath commented Nov 10, 2017

Georgehe4 commented Nov 10, 2017

kwalrath commented Mar 5, 2018 • edited Loading

Georgehe4 commented Mar 5, 2018 via email

kwalrath commented Mar 5, 2018 • edited Loading

chalin commented Apr 20, 2018

Georgehe4 commented May 8, 2018

jcollins-g commented Jun 15, 2018

jcollins-g commented Jun 15, 2018

jcollins-g commented Jun 18, 2018

jcollins-g commented Jun 18, 2018

jcollins-g commented Jul 13, 2018 • edited Loading

RedBrogdon commented Apr 22, 2019

chalin commented Nov 14, 2019

RedBrogdon commented Nov 14, 2019

kwalrath commented Mar 5, 2018 •

edited

Loading

kwalrath commented Mar 5, 2018 •

edited

Loading

jcollins-g commented Jul 13, 2018 •

edited

Loading