Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncaught embedded exceptions on gist loading #829

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

jcollins-g
Copy link
Contributor

Partial fix for #791, at least restoring things to where they were before this cropped up.
@kwalrath

This fixes errors of this form:

async_patch.dart:726 Uncaught Error: DetailedApiRequestError(status: 400, message: main.dart:
Error: No 'main' method found.

Error: Compilation failed.
)
    at Object.a (js_helper.dart:1759)
    at yj.dart.yj.$1 (clients.dart:881)
    at ww.fH (zone.dart:1381)
    at fP.md (future_impl.dart:129)
    at vA.$0 (future_impl.dart:633)
    at Object.ca (future_impl.dart:662)
    at F.aE (future_impl.dart:467)
    at Object.dh (stream_pipe.dart:63)
    at tE.dart.tE.$1 (stream.dart:1149)
    at ww.fI (zone.dart:1316)

They were caused by compilation/running not waiting on the asynchronous gist loading before executing. While the code was always suspect, we might have accidentally not hit this because of implementation details in Dart, and that changed with 2.x.

@jcollins-g jcollins-g merged commit 44a0320 into master Jun 19, 2018
@jcollins-g jcollins-g deleted the fix-uncaught-embedded branch June 19, 2018 17:54
johnpryan pushed a commit to johnpryan/dart-pad that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants