Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove embedded DartPads #422

Closed
chalin opened this issue Nov 9, 2017 · 6 comments
Closed

Remove embedded DartPads #422

chalin opened this issue Nov 9, 2017 · 6 comments
Labels
e2-days Can complete in < 5 days of normal, not dedicated, work infra.design Relates to the design of docs.Dart.dev infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible. st.blocked Issue cannot continue until another action completes

Comments

@chalin
Copy link
Contributor

chalin commented Nov 9, 2017

Known affected pages:

There may be more.

Chrome warnings as seen in the developer console:

@chalin chalin added infra.design Relates to the design of docs.Dart.dev Docs infra.structure Relates to the tools that create dart.dev labels Nov 9, 2017
@kwalrath
Copy link
Contributor

kwalrath commented Nov 9, 2017

Is this caused by embedded DartPads?

@chalin
Copy link
Contributor Author

chalin commented Nov 9, 2017

Ah yes, that could very well be it!

@kwalrath
Copy link
Contributor

I don't see the Blink warning when I view those pages in Chrome Canary: Version 64.0.3261.0 (Official Build) canary (64-bit).

@kwalrath
Copy link
Contributor

kwalrath commented Mar 5, 2018

DartPad's version of Polymer has been updated, but there are now 4 warnings in in https://www.dartlang.org/guides/get-started:

  • [Deprecation] Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M67, around May 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.
  • imports.html:11890 This file is deprecated. Please use iron-flex-layout/iron-flex-layout-classes.html, and one of the specific dom-modules instead
  • imports.html:12193 This file is deprecated. Please use iron-flex-layout/iron-flex-layout-classes.html, and one of the specific dom-modules instead
  • [Deprecation] /deep/ combinator is no longer supported in CSS dynamic profile.It is now effectively no-op, acting as if it were a descendant combinator. /deep/ combinator will be removed, and will be invalid at M65. You should remove it. See https://www.chromestatus.com/features/4964279606312960 for more details.

For more info, see dart-lang/dart-pad#791.

@kwalrath kwalrath changed the title Chrome warnings for Get Started, Language Tour, etc. should be addressed Remove embedded DartPads Jun 15, 2018
@kwalrath kwalrath added p2-medium Necessary but not urgent concern. Resolve when possible. st.blocked Issue cannot continue until another action completes e2-days Can complete in < 5 days of normal, not dedicated, work labels Jan 30, 2019
@kwalrath
Copy link
Contributor

kwalrath commented Jan 30, 2019

Blocked on figuring out what our DartPad strategy will be.

/cc @RedBrogdon

@kwalrath
Copy link
Contributor

kwalrath commented Aug 8, 2019

#1799 switches us to the new DartPad, which causes no console warnings, yay!

@kwalrath kwalrath closed this as completed Aug 8, 2019
@atsansone atsansone removed the docs label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2-days Can complete in < 5 days of normal, not dedicated, work infra.design Relates to the design of docs.Dart.dev infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible. st.blocked Issue cannot continue until another action completes
Projects
None yet
Development

No branches or pull requests

3 participants