Packets 22 and 150 - Game Servers By ID - All #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Preliminary adding, it reads and sends as it should but no real data is sent, just enough to satisfy xfire awaiting something. * This packet deals with fetching all game server information based on Game ID. Added Inbound Packet GameServerFetchAll (22) ! This one sends a numerical attribute name. * It only expects a gameid. From there the server sends back GameServerSendAll packet. Added Outbound Packet GameServerSendAll (150) * Three attributes are sent: gameid, a list of gameips and a list of gameports (both iterates in sync). ! All three attributes are numerical. * I have added as such for future addition: It makes the lists but doesn't populate them and sends back the GameId sent by the client. * In my testing of using a list of hardcoded localhost servers results using Quake 3 and Half-Life 1.5 proved to work, as the base xfire client comes with server query tools built in. XFireMessageType and XFireMessageTypeFactory adds the packets to the lists as needed. MessageSerializer's GetAttributeName now includes GameServerFetchAll as it recieves attributes that aren't strings. I should fix this eventually, as some packets use bytes and others use strings.
| { | ||
| internal sealed class GameServerSendAll : XFireMessage | ||
| { | ||
| public GameServerSendAll(int gameId) : base(XFireMessageType.GameServerSendAll) |
There was a problem hiding this comment.
Should these be unsigned ints? Or are you planning to rebase this with the usigned ints fix and fix it there after?
There was a problem hiding this comment.
I figure to fix it after, base this on the int base and then fix it when the time comes.
|
Many thanks!! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Inbound Packet GameServerFetchAll (22)
! This one sends a numerical attribute name.
Added Outbound Packet GameServerSendAll (150)
XFireMessageType and XFireMessageTypeFactory adds the packets to the lists as needed.
MessageSerializer's GetAttributeName now includes GameServerFetchAll as it recieves attributes that aren't strings. I should fix this eventually, as some packets use bytes and others use strings.