Packets 22 and 150 - Game Servers By ID - All (#45)

* Preliminary adding, it reads and sends as it should but no real data is sent, just enough to satisfy xfire awaiting something.
* This packet deals with fetching all game server information based on Game ID.

Added Inbound Packet GameServerFetchAll (22)
 ! This one sends a numerical attribute name.
 * It only expects a gameid. From there the server sends back GameServerSendAll packet.

Added Outbound Packet GameServerSendAll (150)
 * Three attributes are sent: gameid, a list of gameips and a list of gameports (both iterates in sync).
 ! All three attributes are numerical.
 * I have added as such for future addition: It makes the lists but doesn't populate them and sends back the GameId sent by the client.
 * In my testing of using a list of hardcoded localhost servers results using Quake 3 and Half-Life 1.5 proved to work, as the base xfire client comes with server query tools built in.

XFireMessageType and XFireMessageTypeFactory adds the packets to the lists as needed.

MessageSerializer's GetAttributeName now includes GameServerFetchAll as it recieves attributes that aren't strings. I should fix this eventually, as some packets use bytes and others use strings.

src/PFire.Core/Protocol/MessageSerializer.cs

@@ -64,7 +64,7 @@ private static string GetAttributeName(BinaryReader reader, Type messageType)
             // TODO: Be brave enough to find an elegant fix for this
             // XFire decides not to follow its own rules. Message type 32 does not have a prefix byte for the length of the attribute name
             // and breaks this code. Assume first byte after the attribute count as the attribute name
-            var count = messageType == typeof(StatusChange) ? 1 : reader.ReadByte();
+            var count = (messageType == typeof(StatusChange) || messageType == typeof(GameServerFetchAll)) ? 1 : reader.ReadByte();
 
             var readBytes = reader.ReadBytes(count);
             return Encoding.UTF8.GetString(readBytes);

src/PFire.Core/Protocol/Messages/Inbound/GameServerFetchAll.cs

@@ -0,0 +1,19 @@
+using PFire.Core.Protocol.Messages.Outbound;
+using PFire.Core.Session;
+using System.Threading.Tasks;
+
+namespace PFire.Core.Protocol.Messages.Inbound
+{
+    internal sealed class GameServerFetchAll : XFireMessage
+    {
+        public GameServerFetchAll() : base(XFireMessageType.GameServerFetchAll) { }
+
+        [XMessageField(0x21)]
+        public int GameId { get; set; }
+
+        public override async Task Process(IXFireClient context)
+        {
+            await context.SendAndProcessMessage(new GameServerSendAll(GameId));
+        }
+    }
+}

src/PFire.Core/Protocol/Messages/Outbound/GameServerSendAll.cs

@@ -0,0 +1,39 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Net;
+using System.Threading.Tasks;
+using PFire.Core.Session;
+
+namespace PFire.Core.Protocol.Messages.Outbound
+{
+    internal sealed class GameServerSendAll : XFireMessage
+    {
+        public GameServerSendAll(int gameId) : base(XFireMessageType.GameServerSendAll)
+        {
+            GameId = gameId;
+            GameIps = new List<int>();
+            GamePorts = new List<int>();
+        }
+
+        [XMessageField(0x21)]
+        public int GameId { get; set; }
+
+        [XMessageField(0x22)]
+        public List<int> GameIps { get; set; }
+
+        [XMessageField(0x23)]
+        public List<int> GamePorts { get; set; }
+
+        public override Task Process(IXFireClient context)
+        {
+            //TODO: Have a Database of IPs and Ports that is fetched by gameid
+            //      Send back the GameId sent
+            //      Iterate that into Ips and Ports (unsigned ints on both)
+            //      If no hits, send with empty List<int>s regardless, because the client expects a response.
+
+            return Task.CompletedTask;
+        }
+    }
+}

src/PFire.Core/Protocol/Messages/XFireMessageType.cs

@@ -17,6 +17,7 @@ public enum XFireMessageType : short
         NicknameChange = 14,
         ClientConfiguration = 16,
         ConnectionInformation = 17,
+        GameServerFetchAll = 22,
         StatusChange = 32,
         Unknown37 = 37,
         Logout = 36,
@@ -33,6 +34,7 @@ public enum XFireMessageType : short
         UserLookupResult = 143,
         ServerPong = 144,
         ServerList = 148,
+        GameServerSendAll = 150,
         Groups = 151,
         GroupsFriends = 152,
         FriendStatusChange = 154,

src/PFire.Core/Protocol/XFireMessageTypeFactory.cs

@@ -35,6 +35,7 @@ private XFireMessageTypeFactory()
             Add(new FriendRequestAccept());
             Add(new FriendRequestDecline());
             Add(new FriendRemoval());
+            Add(new GameServerFetchAll());
             Add(new NicknameChange());
             Add(new StatusChange());
             Add(new Logout());