Skip to content

sequence: Changing priors update#32

Open
vimalmanohar wants to merge 29 commits intodanpovey:shortcutfrom
vimalmanohar:shortcut
Open

sequence: Changing priors update#32
vimalmanohar wants to merge 29 commits intodanpovey:shortcutfrom
vimalmanohar:shortcut

Conversation

@vimalmanohar
Copy link

No description provided.

KarelVesely84 and others added 21 commits January 6, 2017 12:48
…AMI; a fix to aspire recipe (kaldi-asr#1314)

* added reverberated TDNN+LSTM recipe on AMI; a fix to aspire recipe

* added script version number
Conflicts:
	src/nnet3/nnet-general-component.cc
nnet3-discriminative-copy-egs ark:$egs_dir/$egs_type.$egs_part.ark ark:- \| \
nnet3-discriminative-subset-egs --srand=JOB --n=$prior_subset_size ark:- ark:- \| \
nnet3-discriminative-merge-egs ark:- ark:- \| \
nnet3-discriminative-merge-egs --minibatch-size=$minibatch_size ark:- ark:- \| \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good generally...
what do you think about changing the $iter.adj.mdl to ${iter}_adj.mdl...
my concern is that with $iter.adj, it may not be clear to the user that the whole
string $iter.adj is treated as the iteration number for the purposes of the decoding script.
With an underscore separation, it's a little easier to see that they hang together.

… issue that Alexander Gorodetski pointed out on list RE a warning.
@danpovey
Copy link
Owner

Thanks-- merging.
You might want to have a look at the aspects of my big PR from the 'shortcut' branch that touch on discriminative training, to see if you spot any problems.
I'm testing it now, on tedlium s5_r2, but it's not super fast to test, obviously. I may ask for help testing it when I think it's fully stabilized (which will be quite soon).

@danpovey
Copy link
Owner

Oh, wait, sorry... I've moved the main development to the 'shortcut' branch in the official Kaldi repo, this branch is dead now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.