Remove touch in fisher_swbd/s5/local/chain/run_blstm_6h.sh#1320
Merged
danpovey merged 2 commits intokaldi-asr:masterfrom Jan 7, 2017
stanleyguan:stan/mkdir_bf_touch
Merged
Remove touch in fisher_swbd/s5/local/chain/run_blstm_6h.sh#1320danpovey merged 2 commits intokaldi-asr:masterfrom stanleyguan:stan/mkdir_bf_touch
danpovey merged 2 commits intokaldi-asr:masterfrom
stanleyguan:stan/mkdir_bf_touch
Conversation
Contributor
|
@danpovey LGTM. But do we still need this? It was for tuning and should be deprecated now? |
danpovey
reviewed
Jan 6, 2017
|
|
||
| touch $dir/egs/.nodelete # keep egs around when that run dies. | ||
| # keep egs around when that run dies. | ||
| mkdir $dir/egs |
Contributor
There was a problem hiding this comment.
it would be better to just remove the "touch" command altogether-- in any case the 'mkdir' command would cause the script to die if run after partial run since the dir would already exist [would need the -p].
Contributor
Author
There was a problem hiding this comment.
So if training dies in one of the iterations, without the "touch" I can still restart from that iteration without having to create egs again?
Contributor
|
Yes, it won't delete the egs if it fails. the comment was wrong.
…On Fri, Jan 6, 2017 at 2:37 PM, Z. Stanley Guan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In egs/fisher_swbd/s5/local/chain/run_blstm_6h.sh
<#1320>:
> @@ -107,7 +107,9 @@ if [ $stage -le 13 ]; then
/export/b0{5,6,7,8}/$USER/kaldi-data/egs/fisher_swbd-$(date +'%m_%d_%H_%M')/s5c/$dir/egs/storage $dir/egs/storage
fi
- touch $dir/egs/.nodelete # keep egs around when that run dies.
+ # keep egs around when that run dies.
+ mkdir $dir/egs
So if training dies in one of the iterations, without the touch I can
still restart from that iteration without having to create egs again?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1320>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADJVux3MBygt5zTLIVBGEymF-lP6PCSvks5rPsJAgaJpZM4Lc0hr>
.
|
stanleyguan
changed the title
Contributor
Author
|
Made a new commit to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the directory does not exist before running
train.py