sequence: Remove deprecated options which are no longer used

[vimalmanohar]

Remove deprecated functions used in nnet3-modify-learning-rates binary, such as ScaleLearningRate and SetLearningRates. These could be added to nnet edits-config if needed.

[danpovey]

Did you make sure they are not used in any scripts?

…

On Thu, Jan 12, 2017 at 10:33 AM, Vimal Manohar ***@***.***> wrote: Remove deprecated functions used in nnet3-modify-learning-rates binary, such as ScaleLearningRate and SetLearningRates. These could be added to nnet edits-config if needed. ------------------------------ You can view, comment on, or merge this pull request online at: #1335 Commit Summary - sequence: Remove deprecated options which are no longer used File Changes - *M* src/nnet3/nnet-utils.cc <https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-0> (73) - *M* src/nnet3/nnet-utils.h <https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-1> (22) - *M* src/nnet3bin/nnet3-am-copy.cc <https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-2> (8) Patch Links: - https://github.com/kaldi-asr/kaldi/pull/1335.patch - https://github.com/kaldi-asr/kaldi/pull/1335.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1335>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJVu6ytSXpEPE_pLpuvMkNV-GtTDu-Bks5rRnIGgaJpZM4LiFfm> .

[vimalmanohar]

It was used only in nnet3-modify-learning-rates, which is removed. I didn't find any scripts when I searched these options in github. Vimal On Thu, Jan 12, 2017 at 3:32 PM Daniel Povey <notifications@github.com> wrote: Did you make sure they are not used in any scripts?

On Thu, Jan 12, 2017 at 10:33 AM, Vimal Manohar ***@***.***> wrote: Remove deprecated functions used in nnet3-modify-learning-rates binary, such as ScaleLearningRate and SetLearningRates. These could be added to nnet edits-config if needed. ------------------------------ You can view, comment on, or merge this pull request online at: #1335 Commit Summary - sequence: Remove deprecated options which are no longer used File Changes - *M* src/nnet3/nnet-utils.cc <https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-0> (73) - *M* src/nnet3/nnet-utils.h <https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-1> (22) - *M* src/nnet3bin/nnet3-am-copy.cc <https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-2> (8) Patch Links: - https://github.com/kaldi-asr/kaldi/pull/1335.patch - https://github.com/kaldi-asr/kaldi/pull/1335.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1335>, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ADJVu6ytSXpEPE_pLpuvMkNV-GtTDu-Bks5rRnIGgaJpZM4LiFfm

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1335 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEATV8TPgIhmsvL6crzzRrIgPU1nr8oeks5rRo3NgaJpZM4LiFfm> .

…

-- Vimal Manohar PhD Student Electrical & Computer Engineering Johns Hopkins University

[danpovey]

OK, merging. We can add them back later if they're needed for something.