-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XY and Z drift stabilization; replaces #108 #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o stabilization_yml_v2
I am happy with this PR. The Z stabilization is well-tested. The XY stabilization is not used as much and not tested quite as well. |
edyoshikun
reviewed
Jul 2, 2024
edyoshikun
reviewed
Jul 2, 2024
edyoshikun
reviewed
Jul 2, 2024
edyoshikun
reviewed
Jul 2, 2024
edyoshikun
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO (01/19/24):
registration_v2
/mantis/cli/stabilization
and/mantis/analysis/stabilize
estimate_xy_stabilization
should use the z indices calculated byestimate_z_stabilization
@ieivanovestimate_stabilization
should usechannel_name
rather thanchannel_index
, likeestimate_affine
. Is there ever a case where we'd want to use different channels for focus finding and xy stabilization? In not, the config can have just "channel_name" rather thanfocus_finding_channel_index
@ieivanovestimate_stabilization
? Should we collect them usinginput
or is it useful for this function to be non-interactive? - These should be CLI optionsprocess_single_position
andapply_function_to_zyx_and_save
inapply_stabilization
?analysis/stabilize.py
if not used(t_{n}, t_{n+1})
images? Does this computation take a lot of time and is it worth parallelizing? - limiting step is z stabilization, no need to parallelize for nowAdd optional argument toestimate_stabilization
to specify which position name is used for xy stabilization @ieivanovThis PR has the code for:
estimate_stabilization_affine()
stabilize_timalpse()
For the XY stabilization, you can use:
/hpc/projects/comp.micro/mantis/2023_09_22_A549_0.52NA_illum/3-registration/A549_MitoViewGreen_LysoTracker_W3_FOV5_1_phase.zarr
For Z drift, any of the timelapses:
/hpc/projects/comp.micro/mantis/2023_11_01_OpenCell_infection/4-registration/timelapse_7/timelapse_7_phase_registered.zarr