Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded focus finding variables in stabilization algorithm #144

Open
edyoshikun opened this issue Jul 2, 2024 · 3 comments
Open

Hardcoded focus finding variables in stabilization algorithm #144

edyoshikun opened this issue Jul 2, 2024 · 3 comments

Comments

@edyoshikun
Copy link
Contributor

The focus_finding variables such as NA_Illumination and emission_wavelength are currently hardcoded in #128 in line

As we are thinking about the metadata in the zarr stores, it would be nice to have some of these parameters in the zarr store (i.e magnification, pixel size, NA_Detection, illumination). These are also somewhat used in the reconstruction of the datasets. It would Like our update-scale-metadata we could have the entires that are populated after reconstruction and or with update-imaging-metadata or similar.

What do you think @talonchandler @ziw-liu @ieivanov @mattersoflight ?

@ziw-liu
Copy link
Contributor

ziw-liu commented Jul 2, 2024

Actually they already exist in FOV-level .zattr if the channel is reconstructed by recOrder:

    "settings": {
        "birefringence": null,
        "fluorescence": {
            "apply_inverse": {
                "TV_iterations": 1,
                "TV_rho_strength": 0.001,
                "reconstruction_algorithm": "Tikhonov",
                "regularization_strength": 0.5
            },
            "transfer_function": {
                "index_of_refraction_media": 1.0,
                "numerical_aperture_detection": 0.55,
                "wavelength_emission": 0.527,
                "yx_pixel_size": 0.325,
                "z_padding": 5,
                "z_pixel_size": 1.0
            }
        },
        "input_channel_names": [
            "FITC"
        ],
        "phase": null,
        "reconstruction_dimension": 3,
        "time_indices": "all"
    }

@edyoshikun
Copy link
Contributor Author

Ah yes that's right. Thanks @ziw-liu. We will add this functionality in another PR.

@ziw-liu
Copy link
Contributor

ziw-liu commented Jul 2, 2024

However be aware of mehta-lab/recOrder#474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants