Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding to bottom of global mode screen so UI is not flush against bottom #21724

Closed
sync-by-unito bot opened this issue May 30, 2022 · 2 comments · Fixed by #22112
Closed

Add padding to bottom of global mode screen so UI is not flush against bottom #21724

sync-by-unito bot opened this issue May 30, 2022 · 2 comments · Fixed by #22112
Assignees
@ZachJW34
Labels
good first issue Good for newcomers

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022 •
edited by jennifer-shehane
Loading

The list of projects is completely flush with the bottom of the app. Add some padding to get some breathing room here. It feels strange when using.

Gif of behavior

Screen Shot 2022-05-31 at 12 06 14 PM

┆Issue is synchronized with this Jira Task by Unito
┆author: Jennifer Shehane
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1095
┆priority: Lowest
┆sprint: Unification Release Backlog
┆taskType: Task
@jennifer-shehane jennifer-shehane added the good first issue Good for newcomers label May 31, 2022
viniciuspietscher added a commit to viniciuspietscher/cypress that referenced this issue Jun 5, 2022
@viniciuspietscher
fix: add padding (cypress-io#21724)
7b6f09b
@viniciuspietscher viniciuspietscher mentioned this issue Jun 5, 2022
Merged
2 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 30, 2022

The code for this is done in cypress-io/cypress#22112, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

lmiller1990 added a commit that referenced this issue Jun 30, 2022
@viniciuspietscher @marktnoonan
@tbiethman @lmiller1990 @flotwig
fix: add padding to bottom of global mode list (#22112)
2b3ab9a 
* fix: add padding

* fix: add padding (#21724)

* Update packages/launchpad/src/global/GlobalPage.cy.tsx

Co-authored-by: Mark Noonan <[email protected]>

* no longer necessary for this fix

* no longer necessary padding will be added to Main.vue

* add bottom padding

* add percy test

* move percy snapshot out of helper function

Co-authored-by: Mark Noonan <[email protected]>
Co-authored-by: Tyler Biethman <[email protected]>
Co-authored-by: Lachlan Miller <[email protected]>
Co-authored-by: Zach Bloomquist <[email protected]>
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2022

Released in 10.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ZachJW34 ZachJW34

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add padding to bottom of global mode list viniciuspietscher/cypress
2 participants
@jennifer-shehane @ZachJW34