Skip to content

Commit

Permalink
fix: add padding (cypress-io#21724)
Browse files Browse the repository at this point in the history
  • Loading branch information
viniciuspietscher committed Jun 5, 2022
1 parent 7ef8f9c commit 7b6f09b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
7 changes: 7 additions & 0 deletions packages/launchpad/src/global/GlobalPage.cy.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,13 @@ describe('<GlobalPage />', { viewportHeight: 900, viewportWidth: 1200 }, () => {
it('renders projects', () => {
cy.findByText(testProject).should('be.visible')
cy.findByText(testProjectPath).should('be.visible')
// validate that there is some padding on the bottom
cy.get('[data-cy="project-card"]')
.parent()
.invoke('outerHeight')
.then((parentHeight) => {
cy.get('[data-cy="project-card"]').invoke('outerHeight').should('be.lt', parentHeight)
})
})

it('can filter down the projects by name', () => {
Expand Down
7 changes: 4 additions & 3 deletions packages/launchpad/src/global/GlobalPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@
>
{{ t('globalPage.recentProjectsHeader') }}
</h2>
<div
class="pb-24px"
:class="{ 'md:grid md:grid-cols-2 md:gap-24px mb-0': filteredProjects?.length > 1 }">
<div
class="pb-24px"
:class="{ 'md:grid md:grid-cols-2 md:gap-24px mb-0': filteredProjects?.length > 1 }"
>
<GlobalProjectCard
v-for="project in filteredProjects"
:key="project.id"
Expand Down

0 comments on commit 7b6f09b

Please sign in to comment.