Skip to content

Commit

Permalink
fix: add padding to bottom of global mode list (#22112)
Browse files Browse the repository at this point in the history
* fix: add padding

* fix: add padding (#21724)

* Update packages/launchpad/src/global/GlobalPage.cy.tsx

Co-authored-by: Mark Noonan <[email protected]>

* no longer necessary for this fix

* no longer necessary padding will be added to Main.vue

* add bottom padding

* add percy test

* move percy snapshot out of helper function

Co-authored-by: Mark Noonan <[email protected]>
Co-authored-by: Tyler Biethman <[email protected]>
Co-authored-by: Lachlan Miller <[email protected]>
Co-authored-by: Zach Bloomquist <[email protected]>
  • Loading branch information
5 people committed Jun 30, 2022
1 parent 6fefe7d commit 2b3ab9a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions packages/launchpad/cypress/e2e/global-mode.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ describe('Launchpad: Global Mode', () => {
const projectList = ['todos', 'ids', 'cookies', 'plugin-empty']

setupAndValidateProjectsList(projectList)

cy.percySnapshot()
})

it('takes user to the next step when clicking on a project card', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/launchpad/src/Main.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/>
<div
v-else
class="px-24px pt-86px"
class="px-24px pt-86px pb-24px"
>
<BaseError
v-if="query.data.value.baseError"
Expand Down
4 changes: 3 additions & 1 deletion packages/launchpad/src/global/GlobalPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
>
{{ t('globalPage.recentProjectsHeader') }}
</h2>
<div :class="{ 'md:grid md:grid-cols-2 md:gap-24px mb-0': filteredProjects?.length > 1 }">
<div
:class="{ 'md:grid md:grid-cols-2 md:gap-24px mb-0': filteredProjects?.length > 1 }"
>
<GlobalProjectCard
v-for="project in filteredProjects"
:key="project.id"
Expand Down

5 comments on commit 2b3ab9a

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 2b3ab9a Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.1/linux-x64/develop-2b3ab9ac71c07420ad764aa68a443eb5e702b445/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 2b3ab9a Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.1/linux-arm64/develop-2b3ab9ac71c07420ad764aa68a443eb5e702b445/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 2b3ab9a Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.1/darwin-arm64/develop-2b3ab9ac71c07420ad764aa68a443eb5e702b445/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 2b3ab9a Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.1/darwin-x64/develop-2b3ab9ac71c07420ad764aa68a443eb5e702b445/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 2b3ab9a Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.3.1/win32-x64/develop-2b3ab9ac71c07420ad764aa68a443eb5e702b445/cypress.tgz

Please sign in to comment.