Skip to content

Bump version to 0.11.0#371

Merged
masa213f merged 1 commit intomainfrom
bump-v0.11.0
Mar 7, 2022
Merged

Bump version to 0.11.0#371
masa213f merged 1 commit intomainfrom
bump-v0.11.0

Conversation

@masa213f
Copy link
Copy Markdown
Contributor

@masa213f masa213f commented Feb 9, 2022

No description provided.

@masa213f masa213f self-assigned this Feb 9, 2022
CHANGELOG.md Outdated
## [0.11.0] - 2022-02-10

### Added
- Add MySQLCluster v1beta2 (#350, #359)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this description is insufficient.
#350 is an important new feature. Add primaryServiceTemplate and replicaServiceTemplate.
#359 is just a bug fix.

How about explaining the migration for the upgrade of MySQLCluster?
(You only need to change the version of your MySQLCluster, thanks to the conversion webhook.)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I wrote about MySQLCluster v1beta2.

I don't think #359 (and #376) need not list individually. They are part of the implementation of MySQLCluster v1beta2.

morimoto-cybozu
morimoto-cybozu previously approved these changes Feb 9, 2022
Copy link
Copy Markdown
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morimoto-cybozu morimoto-cybozu dismissed their stale review February 9, 2022 09:44

agree with zoetrope

@masa213f masa213f requested a review from zoetrope March 3, 2022 03:07
zoetrope
zoetrope previously approved these changes Mar 4, 2022
Copy link
Copy Markdown
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated

## [0.11.0] - 2022-03-03

In 0.11.0, we have introduced the new API version v1beta2 for the MySQLCluster and the BackupPolicy.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of thing should be noted in a release note too.
It might be good to leave the CHANGELOG to include only the list of changes.

What do you think?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

I will revert this explanation and include only the changes in the CHANGELOG.
And after the release, I will write the explanation to the GitHub Releases page.

@ymmt2005
Copy link
Copy Markdown
Member

ymmt2005 commented Mar 4, 2022

@masa213f @morimoto-cybozu
Please include #381.

Copy link
Copy Markdown
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit 1604352 into main Mar 7, 2022
@masa213f masa213f deleted the bump-v0.11.0 branch March 7, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants