Skip to content

Update how-to doc to grant PROXY when replicating cluster from outside#381

Merged
morimoto-cybozu merged 1 commit intomainfrom
update-usage
Mar 4, 2022
Merged

Update how-to doc to grant PROXY when replicating cluster from outside#381
morimoto-cybozu merged 1 commit intomainfrom
update-usage

Conversation

@morimoto-cybozu
Copy link
Copy Markdown
Contributor

@morimoto-cybozu morimoto-cybozu commented Mar 4, 2022

to fix #375

@morimoto-cybozu morimoto-cybozu self-assigned this Mar 4, 2022
@morimoto-cybozu morimoto-cybozu requested a review from arosh March 4, 2022 09:05
arosh
arosh previously approved these changes Mar 4, 2022
Copy link
Copy Markdown
Member

@arosh arosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/usage.md Outdated
mysql> GRANT PROXY ON ''@'' TO 'clone-init'@'localhost' WITH GRANT OPTION;
```

[^note]: The line of `GRANT PROXY ...` has been added for moco-agent >= 0.6.9 in response to [cybozu-go/moco-agent#58](https://github.com/cybozu-go/moco-agent/pull/58).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section describes a setup for cloning an external mysqld which is not necessarily a moco cluster.
So, I guess this note is misleading or at least is difficult to understand.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I'll delete this note.
What I wanted to say was "please don't miss the last line! It has been added!" so this note is just a transient advisory.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, shall we write that in the release note?

Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
Copy link
Copy Markdown
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morimoto-cybozu morimoto-cybozu merged commit ee30157 into main Mar 4, 2022
@morimoto-cybozu morimoto-cybozu deleted the update-usage branch March 4, 2022 11:00
@ymmt2005 ymmt2005 mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

failed to grant PROXY privilege to moco-admin

3 participants