Copy values to replicaServiceTemplate in conversion webhook#376
Merged
Copy values to replicaServiceTemplate in conversion webhook#376
Conversation
masa213f
requested changes
Feb 25, 2022
Contributor
masa213f
left a comment
masa213f
left a comment
There was a problem hiding this comment.
Thank you for this PR.
I found that, in some cases, the round-trip conversion does not work.
When I create a v1beta2 MySQLCluster with primaryServiceTemplate only, the created resource has an unexpected replicaServiceTemplate field.
Could you fix it and add more tests?
d-kuro
force-pushed
the
d-kuro/service-template
branch
2 times, most recently
from
7e036cc to
1035096
Compare
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
d-kuro
force-pushed
the
d-kuro/service-template
branch
from
1035096 to
2ee2f81
Compare
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
d-kuro
force-pushed
the
d-kuro/service-template
branch
from
31a0c21 to
f37e8b6
Compare
Contributor
Author
|
@masa213f |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy
v1beta1.serviceTemplatetov1beta2.primaryServiceTempalateandv1beta2.replicaServiceTemplatewhen converting from v1beta1 to v1beta2 with MySQLCluster conversion.