[Core] Extract Plugin module #1774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of v5 we will break the plugin API by moving packages from `cucumber.core` to `io.cucumber.core`. We can use this as an opportunity to extract the plugin and event classes to separate modules. This change moves `io.cucumber.core.plugin` to `io.cucumber.plugin` and `io.cucumber.core.event` to `io.cucumber.event`. While on its own this change provides little value it will allow us in the future to provide better support for plugins. With the introduction of JPMS we will want to expose these classes for plugin developers. However we also want to avoid the use of core by most end users. By moving these classes to their own modules we can avoid the use of core and future proof the introduction of JPMS. These classes may have been better of in one single module but I can't think of a name that would describe such a module accurately.
|
I guess rev-api has a point:
So one module and I don't know what to call it yet. |
mpkorstanje
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the introduction of v5 we will break the plugin API by moving
packages from
cucumber.coretoio.cucumber.core. We can use thisas an opportunity to extract the plugin and event classes to separate
modules.
This change moves
io.cucumber.core.plugintoio.cucumber.pluginandio.cucumber.core.eventtoio.cucumber.plugin.event. While on its own thischange provides little value it will allow us in the future to provide
better support for plugins.
With the introduction of JPMS we will want to expose these classes for
plugin developers. However we also want to avoid the use of core by most
end users. By moving these classes to their own modules we can avoid the
use of core and future proof the introduction of JPMS.
Closes #1773.
Types of changes