Consolidate duplicate CucumberOptions implementations

[aslakhellesoy]

Both cucumber-junit and cucumber-testng implement their own CucumberOptions annotation. They are identical and should be moved to cucumber-core.

[aslakhellesoy]

The testng implementation does not have useFileNameCompatibleName and stepNotifications. Perhaps these could be removed, or we could use inheritance?

[mpkorstanje]

I split these intentionally to improve the encapsulation of cucumber-core. The end user should not not have to deal with cucumber-core ever. It does result in some duplication (see also Scenario) but this duplication is worth it IMO. This process is not complete, I still need to work on a solution for Plugins and Events and #1768 will allow us to remove the TypeRegistryConfigurer.

In detail the concrete reasons for introducing runner specific @CucumberOptions were:

1. There are difference in configuration between TestNG and JUnit and there may be others in the future. Pulling these changes up into core would result in runner specific code paths in core. This was less then ideal.

2. With the introduction of JPMs we'll have to declare which modules we require and which we require transitively. To keep this simple a typical user of Cucumber with dependencies on

• cucumber-java
• cucumber-junit
• cucumber-pico

Will now only need to import classes from

• io.cucumber.java
• io.cucumber.junit
• io.cucumber.datatable
• io.cucumber.docstring

This means that cucumber-java can require transitively docstring and datatable so a user who depends on java will automatically have access to everything he needs.

[mpkorstanje]

I still need to work on a solution for Plugins and Events

Comes to mind that it might be worth delaying V5 for this a bit more and pull extract the events and plugin interfaces to a separate module.

[mpkorstanje]

Perhaps these could be removed, or we could use inheritance?

Unfortunately this is not possible with annotations.