[Core] Remove detail parameter from getLocation

All glue definition classes implemented a `getLocation(boolean detail)`
method. This would provide a long form method description. However
in practice this method was always invoked with true. Removing the
parameter cleans up the API.

This also revealed that `Invoker` is only used for the `timeout` in
`cucumber-java8`. This means that class can be moved to `cucumber-java`
and with that `MethodFormat` can also be moved to `cucumber-java`.

Author: mpkorstanje

core/src/main/java/io/cucumber/core/backend/DataTableTypeDefinition.java

@@ -12,8 +12,7 @@ public interface DataTableTypeDefinition {
      * The source line where the data table type is defined.
      * Example: com/example/app/Cucumber.test():42
      *
-     * @param detail true if extra detailed location information should be included.
      * @return The source line of the step definition.
      */
-    String getLocation(boolean detail);
+    String getLocation();
 }

core/src/main/java/io/cucumber/core/backend/DefaultDataTableCellTransformerDefinition.java

@@ -12,9 +12,8 @@ public interface DefaultDataTableCellTransformerDefinition {
      * The source line where the default data table cell  is defined.
      * Example: com/example/app/Cucumber.test():42
      *
-     * @param detail true if extra detailed location information should be included.
      * @return The source line of the step definition.
      */
-    String getLocation(boolean detail);
+    String getLocation();
 
 }

core/src/main/java/io/cucumber/core/backend/DefaultDataTableEntryTransformerDefinition.java

@@ -14,8 +14,7 @@ public interface DefaultDataTableEntryTransformerDefinition {
      * The source line where the default table entry transformer is defined.
      * Example: com/example/app/Cucumber.test():42
      *
-     * @param detail true if extra detailed location information should be included.
      * @return The source line of the step definition.
      */
-    String getLocation(boolean detail);
+    String getLocation();
 }

core/src/main/java/io/cucumber/core/backend/DefaultParameterTransformerDefinition.java

@@ -12,8 +12,7 @@ public interface DefaultParameterTransformerDefinition {
      * The source line where the default parameter transformer is defined.
      * Example: com/example/app/Cucumber.test():42
      *
-     * @param detail true if extra detailed location information should be included.
      * @return The source line of the step definition.
      */
-    String getLocation(boolean detail);
+    String getLocation();
 }

core/src/main/java/io/cucumber/core/backend/DocStringTypeDefinition.java

@@ -12,8 +12,7 @@ public interface DocStringTypeDefinition {
      * The source line where the parameter type is defined.
      * Example: com/example/app/Cucumber.test():42
      *
-     * @param detail true if extra detailed location information should be included.
      * @return The source line of the step definition.
      */
-    String getLocation(boolean detail);
+    String getLocation();
 }

core/src/main/java/io/cucumber/core/backend/HookDefinition.java

@@ -6,12 +6,11 @@
 public interface HookDefinition {
     /**
      * The source line where the step definition is defined.
-     * Example: foo/bar/Zap.brainfuck:42
+     * Example: com/example/app/Cucumber.test():42
      *
-     * @param detail true if extra detailed location information should be included.
      * @return The source line where the step definition is defined.
      */
-    String getLocation(boolean detail);
+    String getLocation();
 
     void execute(Scenario scenario) throws Throwable;
 

core/src/main/java/io/cucumber/core/backend/ParameterTypeDefinition.java

@@ -12,8 +12,7 @@ public interface ParameterTypeDefinition {
      * The source line where the parameter type is defined.
      * Example: com/example/app/Cucumber.test():42
      *
-     * @param detail true if extra detailed location information should be included.
      * @return The source line of the step definition.
      */
-    String getLocation(boolean detail);
+    String getLocation();
 }

core/src/main/java/io/cucumber/core/event/StepDefinition.java

@@ -10,10 +10,9 @@ public interface StepDefinition {
      * The source line where the step definition is defined.
      * Example: com/example/app/Cucumber.test():42
      *
-     * @param detail true if extra detailed location information should be included.
      * @return The source line of the step definition.
      */
-    String getLocation(boolean detail);
+    String getLocation();
 
     /**
      * @return the pattern associated with this instance. Used for error reporting only.

core/src/main/java/io/cucumber/core/options/Constants.java

@@ -1,5 +1,7 @@
 package io.cucumber.core.options;
 
+import io.cucumber.core.runtime.ObjectFactoryServiceLoader;
+
 public final class Constants {
 
     /**
@@ -125,7 +127,7 @@ public final class Constants {
      * Property name used to select a specific object factory implementation:
      * {@value}
      *
-     * @see io.cucumber.core.backend.ObjectFactoryServiceLoader
+     * @see ObjectFactoryServiceLoader
      */
     public static final String OBJECT_FACTORY_PROPERTY_NAME = "cucumber.object-factory";
 

core/src/main/java/io/cucumber/core/plugin/UnusedStepsSummaryPrinter.java

@@ -33,7 +33,7 @@ public void setEventPublisher(EventPublisher publisher) {
 	}
 
 	private void handleStepDefinedEvent(StepDefinedEvent event) {
-		registeredSteps.put(event.getStepDefinition().getLocation(false), event.getStepDefinition().getPattern());
+		registeredSteps.put(event.getStepDefinition().getLocation(), event.getStepDefinition().getPattern());
 	}
 
 	private void handleTestStepFinished(TestStepFinished event) {