Skip to content

fix: ParameterType constructor #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2022
Merged

fix: ParameterType constructor #178

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed14cec
fix: ParameterType constructor
unional Oct 27, 2022
775860f
chore: update changelog
unional Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions javascript/src/ParameterType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ export default class ParameterType<T> {
public readonly name: string | undefined,
regexps: RegExps,
public readonly type: Constructor<T> | Factory<T> | null,
transform: (...match: string[]) => T | PromiseLike<T>,
public readonly useForSnippets: boolean,
public readonly preferForRegexpMatch: boolean
transform?: (...match: string[]) => T | PromiseLike<T>,
public readonly useForSnippets?: boolean,
public readonly preferForRegexpMatch?: boolean
) {
if (transform === undefined) {
transform = (s) => s as unknown as T
Expand Down