Win CI: Fix and enable compiler specs#9348
Conversation
This comment has been minimized.
This comment has been minimized.
c436c9d to
f142b31
Compare
|
Finally, now that there are no dependencies on other PRs, I squashed all that merge-mess :> |
|
I'm a bit confused as to the reason for many of these failing specs. I'd rather not make specs pending if we don't understand why they're broken, so could you give some details? |
|
Currently all of the specs are effectively pending, I just reduce that to a dozen. I really just don't know why these things don't work. There are no stack traces. I'm tired. Where I did know, I already fixed them. Many of them. Now I just want to stop the Additionally, I consider merging fixes to these specs before enabling specs as strictly worse; then the fix PRs have no representation in specs even if something happens to be fixed (while with this in you just flip it back from pending). Showing the specs as what they are is good. Best (bad) example: #9387 changes specs for seemingly no reason, but actually they were failing before, if they were to run. Then it even marks a related spec as pending, as if the commit breaks that spec??? |
jhass
left a comment
There was a problem hiding this comment.
This looks good! Windows support is a big task and any incremental improvements are good.
|
For the record, this PR is inconsequential for the 0.35.0 release (changes only specs), so definitely feel free to postpone it to after that |
They've essentially been pending all the time because they're not included in Thanks for your efforts @oprypin |
RX14
left a comment
There was a problem hiding this comment.
Yeah, you're right, this is better, my bad!
|
🎉 |
No description provided.