Skip to content

Compiler: add a few missing expanded.transform self#9506

Merged
asterite merged 1 commit intocrystal-lang:masterfrom
asterite:bug/missing-expanded-transform
Jun 29, 2020
Merged

Compiler: add a few missing expanded.transform self#9506
asterite merged 1 commit intocrystal-lang:masterfrom
asterite:bug/missing-expanded-transform

Conversation

@asterite
Copy link
Member

Fixes #9439

Sorry that there are no tests, I couldn't find an easy way to make a test that exposes these missing things.

@oprypin Can you confirm that this actually fixes the issue?

Copy link
Member

@jhass jhass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows CI passing should be test enough :D @oprypin maybe there's some specs we can enable right here now?

@jhass
Copy link
Member

jhass commented Jun 18, 2020

Mmh, actually it seems to break everything? 😅

@asterite
Copy link
Member Author

I should have only done it for Global.

@asterite asterite force-pushed the bug/missing-expanded-transform branch from d276371 to da4beac Compare June 18, 2020 20:49
@asterite
Copy link
Member Author

I was in a rush and I added an extra transform self that was needed 😊

I think this should work.

By the way, I'm doing these almost blindly because when I compile the compiler and then try to compile anything I get "illegal instruction". Probably something related to my set-up.

@oprypin
Copy link
Member

oprypin commented Jun 18, 2020

Thanks, yes, I confirm this fixes #9439, and makes that example pass on Windows, and also fixes corresponding specs.
https://github.com/oprypin/crystal/commits/b91a3e5f77506762a44dd7d26b421a5cfdb17bf3
(the specs can't be "enabled" as part of this PR yet because they haven't been declared to be pending yet, in #9348).

@jhass jhass added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic labels Jun 18, 2020
@oprypin
Copy link
Member

oprypin commented Jun 23, 2020

Now it is possible to enable those specs, by merging master and cherry-picking b91a3e5. E.g.

git pull origin master
git fetch https://github.com/oprypin/crystal b91a3e5f77506762a44dd7d26b421a5cfdb17bf3
git cherry-pick FETCH_HEAD

@asterite asterite added this to the 1.0.0 milestone Jun 29, 2020
@asterite asterite merged commit b32d3b4 into crystal-lang:master Jun 29, 2020
@asterite asterite deleted the bug/missing-expanded-transform branch June 29, 2020 18:57
oprypin added a commit to oprypin/crystal that referenced this pull request Jun 29, 2020
jhass pushed a commit that referenced this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$? $~ don't seem to work on Windows

3 participants