Improve spec helpers, prepare for compiler specs on Windows#9351
Merged
bcardiff merged 8 commits intocrystal-lang:masterfrom Jun 2, 2020
Merged
Improve spec helpers, prepare for compiler specs on Windows#9351bcardiff merged 8 commits intocrystal-lang:masterfrom
bcardiff merged 8 commits intocrystal-lang:masterfrom
Conversation
Member
|
the compiler-specific parts of This PR as-is makes the stdlib spec suite require the compiler source. |
Member
Author
|
It's not compiler-specific, it's for |
Member
Author
|
Yeah this is better. Instead of moving it to the top level spec_helper and switching files to use it, I move it to a file that is then |
straight-shoota
approved these changes
May 28, 2020
Member
Author
|
Please review |
RX14
approved these changes
May 31, 2020
straight-shoota
added
kind:specs
platform:windows
Member
|
@oprypin this PR is in conflict with master now. Other than that LGTM. |
Member
Author
|
third merge is the charm? |
Sija
reviewed
Jun 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extracted self-contained parts of #9348 so that this is easier to review